Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attack_weight does not function as advertised #3923

Open
CelticMinstrel opened this issue Feb 10, 2019 · 2 comments
Open

attack_weight does not function as advertised #3923

CelticMinstrel opened this issue Feb 10, 2019 · 2 comments
Labels
Bug Issues involving unexpected behavior. Docs Documentation issues, both in-game and otherwise (e.g. manual and manpages). Good first issue Issues deemed adequate for contributors without prior experience to work on. Units Issues that involve unit definitions or their implementation in the engine. WML Issues involving the WML engine or WML APIs.

Comments

@CelticMinstrel
Copy link
Member

Reported on the forums

Attack and defense weight are treated as a boolean setting rather than a true weighting.
@CelticMinstrel CelticMinstrel added Bug Issues involving unexpected behavior. WML Issues involving the WML engine or WML APIs. Units Issues that involve unit definitions or their implementation in the engine. labels Feb 10, 2019
@CelticMinstrel
Copy link
Member Author

Perusal of the code suggests that only attack_weight is broken and defense_weight actually is used as a weighting.

@sevu sevu added Docs Documentation issues, both in-game and otherwise (e.g. manual and manpages). Good first issue Issues deemed adequate for contributors without prior experience to work on. labels Mar 3, 2019
@ProditorMagnus ProditorMagnus mentioned this issue Mar 14, 2019
Open
@CelticMinstrel CelticMinstrel changed the title attack_weight and defense_weight do not function as advertised attack_weight does not function as advertised Nov 9, 2019
@cooljeanius
Copy link
Contributor

Perusal of the code suggests that only attack_weight is broken and defense_weight actually is used as a weighting.

The documentation on the wiki is worded kind of confusingly in this regards; it makes it sound like they're both broken...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues involving unexpected behavior. Docs Documentation issues, both in-game and otherwise (e.g. manual and manpages). Good first issue Issues deemed adequate for contributors without prior experience to work on. Units Issues that involve unit definitions or their implementation in the engine. WML Issues involving the WML engine or WML APIs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CelticMinstrel @cooljeanius @sevu