Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wesnoth.unit_types and wesnoth.terrain_types are now available in map generation scripts #5838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CelticMinstrel
Copy link
Member

For example, this could allow you to tailor a map to the movement of a specific unit type, or modify terrain based on properties rather than just the terrain code.

@CelticMinstrel
Copy link
Member Author

What uses the newly-available functions during map generation, or in other words what tests this new functionality?

Nothing yet. I can definitely think of use-cases, but none have been written yet.

It's fine if this doesn't go into 1.16. Perhaps when I finally get back to #993 some use-cases for this can be included.

@github-actions github-actions bot added the Lua API Issues with the Lua engine and API. label Jun 7, 2021
Copy link
Contributor

@stevecotton stevecotton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What uses the newly-available functions during map generation, or in other words what tests this new functionality?

Nothing yet. I can definitely think of use-cases, but none have been written yet.

Then I think it's not ready for merging, and most definitely not 10 days before API freeze.

@Pentarctagon
Copy link
Member

Any update on this?

@CelticMinstrel
Copy link
Member Author

CelticMinstrel commented Jun 28, 2022

It's on the roadmap for… I think the release after next? Or more generally, once the events PR is finished. I'll likely fold it into #993 along with some example use-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lua API Issues with the Lua engine and API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants