Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRoW][Campaign][Units] Update Haldric Sprites #7121

Open
knyghtmare opened this issue Nov 13, 2022 · 7 comments
Open

[TRoW][Campaign][Units] Update Haldric Sprites #7121

knyghtmare opened this issue Nov 13, 2022 · 7 comments
Labels
Campaign TRoW The mainline The Rise of Wesnoth campaign Enhancement Issues that are requests for new features or changes to existing ones. Graphics Issues that involve the graphics engine or assets. Units Issues that involve unit definitions or their implementation in the engine.

Comments

@knyghtmare
Copy link
Member

Describe the desired feature

Context

Wesnoth 1.4 (March 2008)

Screenshot 2022-11-13 at 8 55 42 PM

Wesnoth 1.16 (October 2021)

Screenshot 2022-11-13 at 8 56 31 PM

Summary:

As it can be seen above, the graphics for Haldric has not been updated for over...2022-2008 = 14 years. Thus, a graphics update would be nice to see.

@knyghtmare knyghtmare added Enhancement Issues that are requests for new features or changes to existing ones. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Graphics Issues that involve the graphics engine or assets. Units Issues that involve unit definitions or their implementation in the engine. labels Nov 13, 2022
@cooljeanius
Copy link
Contributor

cooljeanius commented Nov 14, 2022

As it can be seen above, the graphics for Haldric has not been updated for over...2022-2008 = 14 years. Thus, a graphics update would be nice to see.

Haldric is perfect as-is; he hasn't seen any updates in 14 years because he doesn't need any.

@Wedge009
Copy link
Member

Wedge009 commented Jul 4, 2023

I agree that an update just for the sake of age isn't a reason in itself. However, there's a similar request in #6815 which I think is justified because the sprites that Deoran is based on have since been updated.

Haldric's portrait was last updated in 1.9.2 (6c523de). Perhaps the sprites could also be updated to match them better (similar to how Li'sar's portraits and then sprites were also updated, although Li'sar's change in appearance was a lot more dramatic than Haldric's change). I wouldn't call this a high priority, however.

@stevecotton stevecotton added Campaign TRoW The mainline The Rise of Wesnoth campaign and removed Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign labels Dec 8, 2023
@AnekronCZ
Copy link

I would say an update should be at least considered and I'll try to provide some reasons:

image

  • next to some current loyalist sprites, Haldric doesn't even look like lvl 3 unit anymore; he's far too small, barely larger than even a spearman
  • it gets even more apparent when Haldric stands next to a mounted unit; for precisely that reason I rather swapped the current sprite in my UMC for Vyncyn's from the forums, even though that one doesn't have animations
  • the sprite doesn't respect TC
  • there's no animation for Haldric using the Ruby of Fire, while Konrad gets one for the Sceptre. If there was a new sprite, it could be made with that animation on top of the current ones
  • some animations are of questionable quality, namely the defense sprites; Haldric just holds the sword next to his head for some reason

I agree with egallager that Haldric's look is iconic and I think any update should respect the original art and stick somewhat close to it (striped pants are a must!). Yet I feel there are good reasons to carefully improve on what we already have.

@cooljeanius
Copy link
Contributor

  • next to some current loyalist sprites, Haldric doesn't even look like lvl 3 unit anymore; he's far too small, barely larger than even a spearman

"Creeping biggerism" is a trend to be resisted, not accomodated.

  • the sprite doesn't respect TC

  • there's no animation for Haldric using the Ruby of Fire, while Konrad gets one for the Sceptre. If there was a new sprite, it could be made with that animation on top of the current ones

  • some animations are of questionable quality, namely the defense sprites; Haldric just holds the sword next to his head for some reason

These 3 points are all fair; I think an update that adds team coloring and some additional animation frames would be an improvement.

I agree with egallager that Haldric's look is iconic and I think any update should respect the original art and stick somewhat close to it (striped pants are a must!).

Besides the striped pants, I'd say that keeping his sword disproportionately oversized, in an anime-style fashion, is also important.

@MechanicalDragon963
Copy link
Contributor

But his sword is quite proportionately big...

@cooljeanius
Copy link
Contributor

But his sword is quite proportionately big...

well, ok, proportionately or disproportionately, the point is, it should be big like Cloud Strife's Buster Sword

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign TRoW The mainline The Rise of Wesnoth campaign Enhancement Issues that are requests for new features or changes to existing ones. Graphics Issues that involve the graphics engine or assets. Units Issues that involve unit definitions or their implementation in the engine.
Projects
None yet
Development

No branches or pull requests

7 participants
@stevecotton @cooljeanius @knyghtmare @Wedge009 @MechanicalDragon963 @AnekronCZ and others