Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR S02_01 Infested Caves: South door is a wall #8493

Open
stevecotton opened this issue Mar 4, 2024 · 5 comments
Open

NR S02_01 Infested Caves: South door is a wall #8493

stevecotton opened this issue Mar 4, 2024 · 5 comments
Labels
Campaign NR The mainline Northern Rebirth campaign Enhancement Issues that are requests for new features or changes to existing ones. Prose Issues with prose text for the game.

Comments

@stevecotton
Copy link
Contributor

Language

en_US

Source

NR S02_01

Original Text

Depending on whether it's opened from the east or west side:

  • "Hey look, it’s an ancient door. It seems the trolls were too stupid to figure out how to open it."
  • "Hey look, it’s an ancient door. It seems the skeletons were too stupid to find out how to open it."

That pair of strings appear in two places, and they doesn't fit the map terrain in either location. The northern shortcut is now using a pair of gates, so it isn't far off. The southern shortcut is using cave wall terrain, and after opening it we get the string "A large section of wall crumbles away."

Proposed Change

Rewrite these to match the map terrain, or change the map terrain to match the text.

@stevecotton stevecotton added Prose Issues with prose text for the game. Campaign NR The mainline Northern Rebirth campaign labels Mar 4, 2024
@Wedge009 Wedge009 added the Enhancement Issues that are requests for new features or changes to existing ones. label Mar 4, 2024
@stevecotton
Copy link
Contributor Author

For the northern doors "the old door crumbles away" when opened, but on the map they're replaced with the open gate terrain, which looks very much intact.

@Wedge009
Copy link
Member

Wedge009 commented Mar 4, 2024

To clarify, this is the Infested Caves scenario. (I don't always find scenario numbers on their own, especially weird ones like these, helpful.)

The northern gates are at (13,7) and (15, 6). The southern wall is at (16, 26).

The scenario also doesn't consider that Tallin himself could be the one to trigger these events, so telling himself to 'kick it down' sounds silly. Even more silly is the idea of kicking down a solid wall.

@Wedge009
Copy link
Member

Wedge009 commented Mar 4, 2024

For reference, both events (from master):

# Opening a pair of hidden doors - the north one
[event]
name=moveto
[filter]
side=1
x=12,16,15
y=7 ,5 ,5
[/filter]
# Check from which side do we open and use appropriate race in the dialogue.
[if]
[variable]
name=unit.y
equals=7
[/variable]
[then]
[message]
speaker=unit
message= _ "Hey look, it’s an ancient door. It seems the trolls were too stupid to figure out how to open it."
[/message]
# Two trigger fields in this case
{VARIABLE trigger.x "16,15"}
{VARIABLE trigger.y "5,5"}
[/then]
[else]
[message]
speaker=unit
message= _ "Hey look, it’s an ancient door. It seems the skeletons were too stupid to find out how to open it."
[/message]
{VARIABLE trigger.x 12}
{VARIABLE trigger.y 7}
[/else]
[/if]
[message]
speaker=Tallin
message= _ "Well, let’s see what’s behind it."
[/message]
[message]
speaker=unit
message= _ "All right. (<i>Grunt... strain...</i>) It’s not moving. It seems to be stuck."
[/message]
[message]
speaker=Tallin
message= _ "Well, just kick it down then."
[/message]
[message]
speaker=unit
message= _ "... Right."
[/message]
{QUAKE rumble.ogg}
[if]
[variable]
name=unit.y
equals=7
[/variable]
[then]
[terrain]
x=13
y=7
layer=overlay
terrain=^Pr\o
[/terrain]
[/then]
[else]
[terrain]
x=15
y=6
layer=overlay
terrain=^Pr\o
[/terrain]
[/else]
[/if]
[redraw]
side=1
[/redraw]
[message]
speaker=narrator
image=wesnoth-icon.png
message= _ "The old door crumbles away, revealing an old tunnel on the other side."
[/message]
# nested event, to open the second door
[event]
name=moveto
[filter]
side=1
x=14,$trigger.x
y=6,$trigger.y
[/filter]
[if]
[variable]
name=unit.y
equals=6
[/variable]
[then]
[message]
speaker=unit
message= _ "On the end of the passage is another door. I try to open it."
[/message]
[/then]
[else]
[message]
speaker=unit
message= _ "Here is a similar door as the one before. I try to open it."
[/message]
[/else]
[/if]
{QUAKE rumble.ogg}
[terrain]
x=13,15
y=7,6
layer=overlay
terrain=^Pr\o
[/terrain]
[redraw]
side=1
[/redraw]
{CLEAR_VARIABLE trigger}
[/event]
[/event]
# And the south ones
[event]
name=moveto
[filter]
side=1
x=15,17
y=26,27
[/filter]
[if]
[variable]
name=unit.y
equals=26
[/variable]
[then]
[message]
# po: We have different wordings for the sentences.
speaker=unit
message= _ "Hey look, it’s an ancient door. It seems the trolls were too stupid to figure out how to open it."
[/message]
[/then]
[else]
[message]
speaker=unit
message= _ "Hey look, it’s an ancient door. It seems the skeletons were too stupid to find out how to open it."
[/message]
[/else]
[/if]
[message]
speaker=Tallin
message= _ "Well, let’s see what’s behind it."
[/message]
[message]
speaker=unit
message= _ "All right. (<i>Grunt... strain...</i>) It’s not moving. It seems to be stuck."
[/message]
[message]
speaker=Tallin
message= _ "Well, just kick it down then."
[/message]
[message]
speaker=unit
message= _ "... Right."
[/message]
{QUAKE rumble.ogg}
[terrain]
x=15,16,16,17
y=27,26,27,26
terrain=Uu
[/terrain]
[redraw]
side=1
[/redraw]
[message]
speaker=narrator
image=wesnoth-icon.png
message= _ "A large section of wall crumbles away."
[/message]
[/event]

@stevecotton
Copy link
Contributor Author

stevecotton commented Mar 4, 2024

Although they can be opened from both sides, maybe we should use a narrative trick and say that they've been barricaded shut, and the player's unit happens to be on the correct side to open it again.

The event currently opens the passageway immediately, without offering the player a choice to leave it shut, so they won't check the other side without save-loading.

@stevecotton stevecotton changed the title NR S02_01 South door is a wall NR S02_01 Infested Caves: South door is a wall Mar 4, 2024
@sevu
Copy link
Member

sevu commented Mar 4, 2024

or change the map terrain to match the text.

When the new gates terrain were added, I added the rusty gates in the northern part of this map.
I also tried using wooden gates in the south, but didn't use them in the end to avoid bottlenecks. While it is fine in the north, the 2 or 3 hex wide passage which is in use is better here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign NR The mainline Northern Rebirth campaign Enhancement Issues that are requests for new features or changes to existing ones. Prose Issues with prose text for the game.
Projects
None yet
Development

No branches or pull requests

3 participants