Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation glitch introduced with hardware submerge #8789

Open
grz0 opened this issue Apr 21, 2024 · 4 comments
Open

Animation glitch introduced with hardware submerge #8789

grz0 opened this issue Apr 21, 2024 · 4 comments
Labels
Bug Issues involving unexpected behavior. Confirmed Issues that have been successfully reproduced by at least one developer. Graphics Issues that involve the graphics engine or assets. Regression Issues that were not present in previous releases.

Comments

@grz0
Copy link
Contributor

grz0 commented Apr 21, 2024

Game and System Information

The Battle for Wesnoth version 1.19.0-dev (39987cd1ca4c09ea2f5d9de08ecfa3c6b029fe5d-Clean) Nieznana
Running on Freedesktop SDK 23.08 (Flatpak runtime) x86_64
Distribution channel: Flatpak

Description of the bug

After destruction of the bridge, the unit standing in water is glitched. Check video:
Screencast_20240421_002149.webm

Steps to reproduce the behavior

  1. Destroy the bridge

Expected behavior

No response

Additional context

No response
@grz0 grz0 added the Bug Issues involving unexpected behavior. label Apr 21, 2024
@Wedge009 Wedge009 added Graphics Issues that involve the graphics engine or assets. Campaign EI The mainline Eastern Invasion campaign labels Apr 21, 2024
@Wedge009
Copy link
Member

I don't think this is specific to EI but I found another occurrence in S6a Undead Crossing.
image

I confirmed it doesn't occur in 1.18.0 and after bisecting against master I confirmed my suspicion that it was the hardware submerge change that introduced this. #8687 by @Pentarctagon and @mesilliac.

@Wedge009 Wedge009 added Regression Issues that were not present in previous releases. and removed Campaign EI The mainline Eastern Invasion campaign labels May 22, 2024
@Wedge009 Wedge009 changed the title Animation glitch after bridge destruction in EI Evacuation scenario Animation glitch introduced with hardware submerge May 22, 2024
@Pentarctagon
Copy link
Member

Water animations strike again...

@Wedge009
Copy link
Member

Guessing that's a reference to #8845.

@Pentarctagon
Copy link
Member

Also for example the flickering sprite at the start of the video in #6960 (comment)

@Wedge009 Wedge009 added the Confirmed Issues that have been successfully reproduced by at least one developer. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues involving unexpected behavior. Confirmed Issues that have been successfully reproduced by at least one developer. Graphics Issues that involve the graphics engine or assets. Regression Issues that were not present in previous releases.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Pentarctagon @grz0 @Wedge009