Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MULTIPLAYER is defined in the main screen context. #5403

Open
virtualghetto opened this issue Dec 31, 2020 · 6 comments
Open

MULTIPLAYER is defined in the main screen context. #5403

virtualghetto opened this issue Dec 31, 2020 · 6 comments
Labels
Bug Issues involving unexpected behavior. Engine General game engine issues that do not fit in any other category.

Comments

@virtualghetto
Copy link

virtualghetto commented Dec 31, 2020

Game and System Information

  • What version of the game are you running?
  • 1.15.8
  • If you're using a custom build, what compiler did you use, and what commit did you build at?
  • 1.15.8 tag
  • What OS are you running?
  • linux

Describe the bug

When you start wesnoth, MULTIPLAYER is not defined in the context of the main screen.
If you click on Multiplayer -> local game and then click on Cancel to go back to the main screen, the MULTIPLAYER remains defined.

To Reproduce

Steps to reproduce the behavior:

Create a dummy campaign

#ifndef MULTIPLAYER
[campaign]
...
[/campaign]
#endif

This campaign will appear in the Campaigns list when you start wesnoth.
Enter Multiplayer and go back to the main screen with Cancel.
Click on Campaigns again, the dummy campaign will no longer be visible here.

Expected behavior

MULTIPLAYER is undefed when you go back to the main screen.
Or, it should be undefed when you click on Campaigns.

@doofus-01
Copy link
Member

For what it's worth, it's been this way for a very long time.

@soliton- soliton- added Bug Issues involving unexpected behavior. Engine General game engine issues that do not fit in any other category. labels Jan 5, 2021
@gfgtdf
Copy link
Contributor

gfgtdf commented Mar 26, 2023

This is the expected behaviour since, quite some time. If you don't want your campaign to show up in single player you have to use type=mp in [campaign] , see https://wiki.wesnoth.org/CampaignWML

While we could in theory make a guarantee that MULTIPLAYER is not defined on title screen, i think its definitely not worth it since it would result more loading times and thus a worse player experience.

@soliton-
Copy link
Member

Is this expected behaviour documented somewhere?

@gfgtdf
Copy link
Contributor

gfgtdf commented Mar 27, 2023

Hmm not sure, idk where these macros are documented in the first place. I guess https://wiki.wesnoth.org/Preprocessorref is is there some other place ?

@soliton-
Copy link
Member

I don't think there is another place.

@gfgtdf
Copy link
Contributor

gfgtdf commented Mar 27, 2023

updated the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. Engine General game engine issues that do not fit in any other category.
Projects
None yet
Development

No branches or pull requests

4 participants