Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚜 Switch to GHA #29

Merged
merged 2 commits into from
Sep 27, 2023
Merged

🚜 Switch to GHA #29

merged 2 commits into from
Sep 27, 2023

Conversation

jefftriplett
Copy link
Contributor

No description provided.

@jefftriplett jefftriplett marked this pull request as ready for review September 27, 2023 13:26
joshuadavidthomas
joshuadavidthomas approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@joshuadavidthomas joshuadavidthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's some clean workflows right there

@jefftriplett
Copy link
Contributor Author

@joshuadavidthomas I can't tell if the wrappers are completely worth it, but I like that running the same thing on GHA and locally feels like they work the same. So small win I hope and a nice pattern if you add docs.

@jefftriplett jefftriplett merged commit 33f97da into main Sep 27, 2023
24 checks passed
@jefftriplett jefftriplett deleted the switch-nox-gha branch September 27, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuadavidthomas joshuadavidthomas joshuadavidthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jefftriplett @joshuadavidthomas