fix(active_record): ArgumentError in AssociationRelation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is specifically for `AssociationRelation`, which is the class that you get when you chain a `where` onto an association and then try to use methods such as `first_or_initialize` on the result. In Rails 6, the signature of `build`, `create`, and `create!` changed. They no longer accept `*args`. See rails/rails@f1c1c43 for more details on that change. When this gem's patch on `first_or_initialize` delegates to `create`, for example, it tries to pass `options` as a second parameter. This succeeded with the previous signature of these methods, but in Rails 6, this fails as the methods no longer accept a second argument. This commit adds another patch to `AssociationRelation` to override these methods so that they accept the `options` argument and pass it on.
|
Looks good. Great work. |
westonganger
added a commit
that referenced
this pull request
Oct 24, 2020
|
Just a heads up. You forgot to run Appraisal to ensure that the tests succeeded with all Rails versions. I often forget this step as well, so in 60da8e1 I have now added a warning at the end of the default rake task regarding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is specifically for
AssociationRelation, which is the class that you get when you chain awhereonto an association and then try to use methods such asfirst_or_initializeon the result.In Rails 6, the signature of
build,create, andcreate!changed. They no longer accept*args. See rails/rails@f1c1c43 for more details on that change.When this gem's patch on
first_or_initializedelegates tocreate, for example, it tries to passoptionsas a second parameter. This succeeded with the previous signature of these methods, but in Rails 6, this fails as the methods no longer accept a second argument.This commit adds another patch to
AssociationRelationto override these methods so that they accept theoptionsargument and pass it on.Fixes #19