Menu: Fixed JS error in IE8 when clicking menu panel button a second …

…time before the menu panel opens
wet-boew · Jan 10, 2014 · 147dee0 · 147dee0
1 parent eba2c5e
commit 147dee0
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 3 deletions.
diff --git a/src/plugins/overlay/overlay-ie8.scss b/src/plugins/overlay/overlay-ie8.scss
@@ -7,7 +7,38 @@
  *	Overlay base
  */
 .ie8 {
-	.wb-overlay {
-		border: 1px solid #ccc;
+	%overlay-ie8-border-left-999 {
+		border-left: 1px solid #999;
+	}
+
+	%overlay-ie8-border-right-999 {
+		border-left: 1px solid #999;
+	}
+
+	.wb-panel-l {
+		@extend %overlay-ie8-border-right-999;
+	}
+
+	.wb-panel-r {
+		@extend %overlay-ie8-border-left-999;
+	}
+
+	.wb-bar-t {
+		border-bottom: 1px solid #999;
+	}
+
+	.wb-bar-b {
+		border-top: 1px solid #999;
+	}
+	&[dir=rtl] {
+		.wb-panel-l {
+			border-right: none;
+			@extend %overlay-ie8-border-left-999;
+		}
+
+		.wb-panel-r {
+			border-left: none;
+			@extend %overlay-ie8-border-right-999;
+		}
 	}
 }
diff --git a/src/plugins/overlay/overlay.js b/src/plugins/overlay/overlay.js
@@ -196,7 +196,7 @@ $document.on( "click vclick touchstart focusin", "body", function( event ) {
 		// Close any overlays with outside activity
 		for ( overlayId in sourceLinks ) {
 			overlay = document.getElementById( overlayId );
-			if ( overlay.getAttribute( "aria-hidden" ) === "false" &&
+			if ( overlay !== null && overlay.getAttribute( "aria-hidden" ) === "false" &&
 				eventTarget.id !== overlayId &&
 				overlay.className.indexOf( ignoreOutsideClass ) === -1 &&
 				!$.contains( overlay, eventTarget ) ) {