Merge pull request #264 from nschonni/jshint-fail-build

JSHint fail build

.travis.yml

@@ -1,7 +1,7 @@
 language: java
 
-script:
-  - ant
+before_script: 
+  - ant test -Djshint.failbuild=true
 
-after_script: 
-  - ant test
+script:
+  - ant

build/build-tasks.properties

@@ -16,4 +16,5 @@ jruby.jar=${lib.dir}/jruby.jar
 
 #JSLint
 jshint.jar=${lib.dir}/ant-jshint-0.3.1-deps.jar
-jshint.globals.file=${tasks.basedir}/jshint.globals.properties
+jshint.globals.file=${tasks.basedir}/jshint.globals.properties
+jshint.failbuild=false

build/build-tasks.xml

@@ -91,7 +91,7 @@
 	</target>
 
 	<target name="-jshint">
-		<jshint dir="${src.dir}" fail="false" globalsFile="${jshint.globals.file}">
+		<jshint dir="${src.dir}" fail="${jshint.failbuild}" globalsFile="${jshint.globals.file}">
 			<report type="xml" destfile="${build.dir}/jshint.out.xml" />
 			<include name="**/*.js"/>
 			<exclude name="**/*.min.js"/>

build/js/dependencies/equalheights-min.js

@@ -1,17 +1,17 @@
 /*!-------------------------------------------------------------------- 
- * JQuery Plugin: "EqualHeights"
- * by:    Scott Jehl, Todd Parker, Maggie Costello Wachs (http://www.filamentgroup.com)
- *
- * Copyright (c) 2008 Filament Group
- * Licensed under GPL (http://www.opensource.org/licenses/gpl-license.php)
- *
- * Description: Compares the heights or widths of the top-level children of a provided element 
-		and sets their min-height to the tallest height (or width to widest width). Sets in em units 
-		by default if pxToEm() method is available.
- * Dependencies: jQuery library, pxToEm method	(article: 
-		http://www.filamentgroup.com/lab/retaining_scalable_interfaces_with_pixel_to_em_conversion/)							  
- * Usage Example: $(element).equalHeights();
-		Optional: to set min-height in px, pass a true argument: $(element).equalHeights(true);
- * Version: 2.0, 08.01.2008
+* JQuery Plugin: "EqualHeights"
+* by:    Scott Jehl, Todd Parker, Maggie Costello Wachs (http://www.filamentgroup.com)
+*
+* Copyright (c) 2008 Filament Group
+* Licensed under GPL (http://www.opensource.org/licenses/gpl-license.php)
+*
+* Description: Compares the heights or widths of the top-level children of a provided element 
+and sets their min-height to the tallest height (or width to widest width). Sets in em units 
+by default if pxToEm() method is available.
+* Dependencies: jQuery library, pxToEm method	(article: 
+http://www.filamentgroup.com/lab/retaining_scalable_interfaces_with_pixel_to_em_conversion/)
+* Usage Example: $(element).equalHeights();
+Optional: to set min-height in px, pass a true argument: $(element).equalHeights(true);
+* Version: 2.0, 08.01.2008
 --------------------------------------------------------------------*/
 (function(a){a.fn.equalHeights=function(b){a(this).each(function(){var c=0;a(this).children().each(function(){if(a(this).height()>c){c=a(this).height()}});if(!b&&typeof Number.prototype.pxToEm!=="undefined"){c=c.pxToEm()}if(a.browser.msie&&a.browser.version==="6.0"){a(this).children().css({height:c})}a(this).children().css({"min-height":c})});return this}}(jQuery));

src/js/build.xml

@@ -145,12 +145,36 @@
 	<target name="test" depends="-jshint"/>
 
 	<target name="-jshint">
-		<jshint dir="${src.dir}" fail="false" globalsFile="${jshint.globals.file}" options="strict:false">
+		<jshint dir="${src.dir}" fail="${jshint.failbuild}" globalsFile="${jshint.globals.file}" options="strict:false">
 			<report type="xml" destfile="${build.dir}/jshint.out.xml" />
 			<include name="**/*.js"/>
-			<include name="dependencies/calendar.js"/>
 			<exclude name="**/*.min.js"/>
-			<exclude name="dependencies/**/*.js"/>
+			<exclude name="jquery.mobile/jquery.mobile.js"/>
+			<exclude name="polyfills/datalist.js"/>
+			<exclude name="polyfills/detailssummary.js"/>
+			<exclude name="polyfills/html5shiv.js"/>
+			<exclude name="polyfills/localstorage.js"/>
+			<exclude name="polyfills/slider.js"/>
+			<exclude name="workers/parser.table.js"/>
+			<exclude name="workers/webwidget.js"/>
+			<exclude name="dependencies/bookmark.js"/>
+			<exclude name="dependencies/browsertweaks.js"/>
+			<exclude name="dependencies/colorbox.js"/>
+			<exclude name="dependencies/easytabs.js"/>
+			<exclude name="dependencies/hashchange.js"/>
+			<exclude name="dependencies/hoverintent.js"/>
+			<exclude name="dependencies/json.js"/>
+			<exclude name="dependencies/matchMedia.js"/>
+			<exclude name="dependencies/metadata.js"/>
+			<exclude name="dependencies/outside.js"/>
+			<exclude name="dependencies/pie.js"/>
+			<exclude name="dependencies/prettify.js"/>
+			<exclude name="dependencies/prettify/**/*.js"/>
+			<exclude name="dependencies/raphael.js"/>
+			<exclude name="dependencies/resize.js"/>
+			<exclude name="dependencies/validate.js"/>
+			<exclude name="dependencies/validateAdditional.js"/>
+			<exclude name="dependencies/xregexp.js"/>
 		</jshint>
 	</target>
 </project>

src/js/dependencies/equalheights.js

@@ -1,18 +1,18 @@
 /*-------------------------------------------------------------------- 
- * JQuery Plugin: "EqualHeights"
- * by:    Scott Jehl, Todd Parker, Maggie Costello Wachs (http://www.filamentgroup.com)
- *
- * Copyright (c) 2008 Filament Group
- * Licensed under GPL (http://www.opensource.org/licenses/gpl-license.php)
- *
- * Description: Compares the heights or widths of the top-level children of a provided element 
-		and sets their min-height to the tallest height (or width to widest width). Sets in em units 
-		by default if pxToEm() method is available.
- * Dependencies: jQuery library, pxToEm method	(article: 
-		http://www.filamentgroup.com/lab/retaining_scalable_interfaces_with_pixel_to_em_conversion/)							  
- * Usage Example: $(element).equalHeights();
-		Optional: to set min-height in px, pass a true argument: $(element).equalHeights(true);
- * Version: 2.0, 08.01.2008
+* JQuery Plugin: "EqualHeights"
+* by:    Scott Jehl, Todd Parker, Maggie Costello Wachs (http://www.filamentgroup.com)
+*
+* Copyright (c) 2008 Filament Group
+* Licensed under GPL (http://www.opensource.org/licenses/gpl-license.php)
+*
+* Description: Compares the heights or widths of the top-level children of a provided element 
+and sets their min-height to the tallest height (or width to widest width). Sets in em units 
+by default if pxToEm() method is available.
+* Dependencies: jQuery library, pxToEm method	(article: 
+http://www.filamentgroup.com/lab/retaining_scalable_interfaces_with_pixel_to_em_conversion/)
+* Usage Example: $(element).equalHeights();
+Optional: to set min-height in px, pass a true argument: $(element).equalHeights(true);
+* Version: 2.0, 08.01.2008
 --------------------------------------------------------------------*/
 
 (function ($) {
@@ -24,9 +24,9 @@
 			});
 			if (!px && typeof Number.prototype.pxToEm !== 'undefined') { currentTallest = currentTallest.pxToEm(); } //use ems unless px is specified
 			// for ie6, set height since min-height isn't supported
-			if ($.browser.msie && $.browser.version === '6.0') { $(this).children().css({'height': currentTallest}); }
-			$(this).children().css({'min-height': currentTallest});
+			if ($.browser.msie && $.browser.version === '6.0') { $(this).children().css({ 'height': currentTallest }); }
+			$(this).children().css({ 'min-height': currentTallest });
 		});
 		return this;
 	};
-}(jQuery));
+} (jQuery));