Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Accolades page linking to internal GC site #4551

Closed
EricDunsworth opened this issue Feb 12, 2014 · 4 comments
Closed

Documentation: Accolades page linking to internal GC site #4551

EricDunsworth opened this issue Feb 12, 2014 · 4 comments

Comments

@EricDunsworth
Copy link
Member

I've noticed that the Accolades page (http://wet-boew.github.io/wet-boew/docs/ref/accolades-en.html) is linking over to http://www.cco-bcc.gc.ca/news-nouvelles/newsdetails-detailsnouvelles-eng.aspx?nid=715... which is only accessible within the GC's network (kind of like GCPedia).

Would there be any value in removing that link since it's not universally accessible? Otherwise, I guess I'll just exempt it from my future broken link crawls.

@thomasgohard
Copy link
Member

I wouldn't necessarily remove the link, but maybe indicate that the article can only be accessed on a government network.

@pjackson28
Copy link
Member

@EricDunsworth Could you please create PRs for v3.0 and v4.0 to add the mention? Perhaps something like:

  • (internal to GC only)
  • whatever the French equivalent is

@thomasgohard Thoughts on the wording (and suggestion for French)?

@thomasgohard
Copy link
Member

I'm not sure if people will understand "internal to GC only". What about "only accessible on Government of Canada networks"? It's a bit longer, but that way it's clear.

In French that would be "accessible uniquement sur les réseaux du gouvernement du Canada".

@EricDunsworth
Copy link
Member Author

@thomasgohard Thanks :).

@pjackson28 I'll send over some PRs with the adjustment soon-ish (within the next few days) and exempt that domain from my future broken link crawls.

EricDunsworth added a commit to EricDunsworth/wet-boew that referenced this issue Feb 20, 2014
pjackson28 pushed a commit that referenced this issue Feb 20, 2014
Documentation: Updated CCO link text in accolades page. Fixes #4551.
pjackson28 pushed a commit that referenced this issue Feb 20, 2014
Documentation: Updated CCO link text in accolades page. Fixes #4551.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants