New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V4 add csslint to build #3863
V4 add csslint to build #3863
Conversation
The sprite one should be fixed. What is the other one? |
It was in issue with Magnific and the PR is merged, just need a new release. |
Perfect! |
Can you rebase? |
Turn off all failing tests to start
Mostly caused by how Sass treats comment blocks inside selectors. "empty-selector" rule can be turned on after Magnific-popup PR 303
Twitter SCSS wasn't being imported but also had -9999px text-indent.
Performance is bad, so replaced with an extension since the "brdr" classes were the only one using them.
Is this ready to merge? |
I've removed the "zero-units" exlusion now that I've confirmed the grunt-imagine patch worked. I think this is good to go as long as Travis passes this time 😉 |
How do you drop a commit from a rebase? Did you create a new branch and manually cherry pick? |
@LaurentGoderre To drop a commit as part of a rebase, you can run |
I actually just did an interactive rebase and used the |
Initial pass at adding back in the CSSLint validation.