Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 add csslint to build #3863

Merged
merged 6 commits into from Dec 3, 2013

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Dec 3, 2013

Initial pass at adding back in the CSSLint validation.

  • Turned off all failing rules, but they should be reviewed again
  • 2 PRs sent upstream to fix linting issues that can be disabled once they are merged
  • Found Twitter wasn't being imported properly, so it was added back in when enforcing the RTL text-indent rule

@LaurentGoderre
Copy link
Member

The sprite one should be fixed. What is the other one?

@nschonni
Copy link
Member Author

nschonni commented Dec 3, 2013

It was in issue with Magnific and the PR is merged, just need a new release.

@LaurentGoderre
Copy link
Member

Perfect!

@LaurentGoderre
Copy link
Member

Can you rebase?

Turn off all failing tests to start
Mostly caused by how Sass treats comment blocks inside selectors.
"empty-selector" rule can be turned on after Magnific-popup PR 303
Twitter SCSS wasn't being imported but also had -9999px text-indent.
Performance is bad, so replaced with an extension since the "brdr"
classes were the only one using them.
@LaurentGoderre
Copy link
Member

Is this ready to merge?

@nschonni
Copy link
Member Author

nschonni commented Dec 3, 2013

I've removed the "zero-units" exlusion now that I've confirmed the grunt-imagine patch worked. I think this is good to go as long as Travis passes this time 😉

@LaurentGoderre
Copy link
Member

How do you drop a commit from a rebase? Did you create a new branch and manually cherry pick?

LaurentGoderre added a commit that referenced this pull request Dec 3, 2013
@LaurentGoderre LaurentGoderre merged commit 2aef0d7 into wet-boew:v4.0 Dec 3, 2013
@thomasgohard
Copy link
Member

@LaurentGoderre To drop a commit as part of a rebase, you can run git rebase -i and simply delete the line for the commit you want to drop.

@nschonni
Copy link
Member Author

nschonni commented Dec 3, 2013

I actually just did an interactive rebase and used the e or "edit" option to change the commit. If you delete the line during rebase then you can drop a commit from a branch.

@nschonni nschonni deleted the v4-add-csslint-to-build branch December 3, 2013 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants