Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldflow plugin - Initial commit, transform a basic list into a selectable list. #7790

Closed
wants to merge 1 commit into from

Conversation

duboisp
Copy link
Member

@duboisp duboisp commented Nov 30, 2016

Note, the following working example link are based on build 4154900

English working example:

French working example:

Documentation:

i18n temporary workaround

Currently the plugin only support English and French and use a work-around for i18n.

The following text will need to be translated in all language supported by WET, then added to the cvs, then I will be able to update the plugin to fully support the i18n of WET.

  • Button
    • Continue
    • Allez
  • Default selected item
    • Make your selection...
    • Sélectionnez dans la liste...
  • Required
    • required
    • obligatoire

cc/ @TouficS

*
* Add a parameter to the detination URL like "?name=value"
*/
$document.on( "redir." + submitEvent, selector, function( event, data ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse function with previous one and use switch to reduce code duplication

*
* Add a parameter to the detination URL like "?name=value"
*/
$document.on( "query." + actionEvent, selector, function( event, data ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse function with previous one and use switch to reduce code duplication

* @dt: Data structure defining this ajax loading configuration
*
*/
$document.on( "ajax." + actionEvent, selector, function( event, data ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse function with previous one and use switch to reduce code duplication

*
* Add a parameter to the detination URL like "?name=value"
*/
$document.on( "ajax." + submitEvent, selector, function( event, data ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse function with previous one and use switch to reduce code duplication

} );

// Toggle an items
$document.on( "toggle." + actionEvent, selector, function( event, data ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse function with previous one and use switch to reduce code duplication

*
* Add a parameter to the detination URL like "?name=value"
*/
$document.on( "toggle." + submitEvent, selector, function( event, data ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse function with previous one and use switch to reduce code duplication

} );

// addClass action
$document.on( "addClass." + submitEvent, selector, function( event, data ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse function with previous one and use switch to reduce code duplication

} );

// removeClass action
$document.on( "removeClass." + actionEvent, selector, function( event, data ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse function with previous one and use switch to reduce code duplication

} );

// removeClass action
$document.on( "removeClass." + submitEvent, selector, function( event, data ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse function with previous one and use switch to reduce code duplication

} );

// Insert a control next to it
$document.on( "append." + actionEvent, selector, function( event, data ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse function with previous one and use switch to reduce code duplication

@duboisp
Copy link
Member Author

duboisp commented Feb 13, 2017

@LaurentGoderre as you asked, I collapsed all the function with previous one and now it uses a switch. Thanks 👍

@LaurentGoderre
Copy link
Member

Much cleaner and leaner!

@duboisp
Copy link
Member Author

duboisp commented Mar 30, 2017

To be moved into the gc web theme, as this plugin execute business logic.

@duboisp
Copy link
Member Author

duboisp commented Apr 27, 2017

This plugin is merged in GC Web
See working example and docs here: http://wet-boew.github.io/themes-dist/GCWeb/index-en.html

@duboisp duboisp closed this Apr 27, 2017
@duboisp duboisp deleted the fieldflow branch May 19, 2017 02:54
@duboisp duboisp added Feature: Theme plugin and removed Need: Second opinion A solution is provided, but prior to be applied it needs to be backed. Query: Feature Request labels Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants