Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jQuery to final 1.x and 2.x releases #8371

Merged
merged 2 commits into from
May 3, 2018

Conversation

nschonni
Copy link
Member

A markup change might be required for those still supporting IE < 9 and those wanting to opt into the newer 2.x release

Closes #8047

@duboisp
Copy link
Member

duboisp commented Apr 26, 2018

We don't support IE < 9, so I don't think that would be an issue

@nschonni
Copy link
Member Author

Actually, I guess it's the case for the newer browser markup to since we generate out the link to jQuery in our templates

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script>

For implementers, they can do the update if they have the capacity, but since this was always a CDN link rather than a local include.
Might be something to add to the release notes about both

@duboisp
Copy link
Member

duboisp commented May 3, 2018

@nschonni can you fix the conflict then we will merge it.

A note for implementer was added in the pre-release note.

This PR was pre-approved at technical review meeting.

Last of the 2.x branch to resolve a few security issues in the old one
For security issues in old pinned version.
Markup changes required for this, but only affects those supporting IE<9
@nschonni nschonni merged commit 4a9c6fc into wet-boew:master May 3, 2018
@nschonni nschonni deleted the jquery-security branch May 3, 2018 15:27
@RobJohnston RobJohnston mentioned this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants