Feeds plugins: CORS enabled pulling #8502
Conversation
|
@ipaksc it's counter to best practices to add the date to a commit message. It makes the commit very verbose and duplicates info that is already available with the commit. |
ipaksc
force-pushed
the
rsscors
branch
7 times, most recently
from
180b60f
to
c048446
Compare
ipaksc
changed the title
|
Before to merge, I am going to test this PR locally first. |
|
Test URL: http://universallabs.org/wet/labs/pr-8502/demos/feeds/feeds-en.html |
src/plugins/feeds/feeds-en.hbs
Outdated
| @@ -15,6 +15,27 @@ | |||
|
|
|||
| <section> | |||
| <h2>Examples</h2> | |||
| <section class="wb-feeds limit-3" data-cors="true"> | |||
| <h3>Canada News Centre - Manitoba</h3> | |||
There was a problem hiding this comment.
Can you modify the title to indication this example use the CORS?
There was a problem hiding this comment.
Add also a small description explaining: This method fetch the ATOM feed directly and don't use a third party service.
src/plugins/feeds/feeds-fr.hbs
Outdated
| @@ -15,6 +15,27 @@ | |||
|
|
|||
| <section> | |||
| <h2>Exemples</h2> | |||
| <section class="wb-feeds limit-3" data-cors="true"> | |||
| <h3>Centre des nouvelles du Canada - Manitoba</h3> | |||
There was a problem hiding this comment.
Can you modify the title to indication this example use the CORS?
|
What is the net effect of adding data-cors="true" to the mark-up? Is the Yahoo API sill being used? |
|
@fibrahim The yahoo API should not be used. |
|
I updated the test site as per the latest Ilya changes. Now the CORS example is the last working example. Test URL: http://universallabs.org/wet/labs/pr-8502/demos/feeds/feeds-en.html |
ipaksc
force-pushed
the
rsscors
branch
2 times, most recently
from
f6f0486
to
bcb2c67
Compare
src/plugins/feeds/feeds.js
Outdated
| if ( !Array.isArray( data ) ) { | ||
| data = [ data ]; | ||
| // if CORS -> transform the xml response into a JSON | ||
| if ( $( eventTarget ).parentsUntil( selector ).parent().data( "cors" ) === true ) { |
There was a problem hiding this comment.
Can you cache this $( eventTarget ).parentsUntil( selector ).parent() into a variable.
|
I updated the test site as per the latest Ilya changes. Test URL: http://universallabs.org/wet/labs/pr-8502/demos/feeds/feeds-en.html |
|
I updated the test site as per the latest Ilya changes. Test URL: http://universallabs.org/wet/labs/pr-8502/demos/feeds/feeds-en.html |
src/plugins/feeds/feeds.js
Outdated
| * @method corsEntry | ||
| */ | ||
| corsEntry = function( xmlDoc, limit ) { | ||
| var arr_entry = []; |
There was a problem hiding this comment.
Do one "var" declaration instead of multiple, this is to follow the same coding style as we did elsewhere in WET. This apply to other "var" statement you added in your PR.
ipaksc
force-pushed
the
rsscors
branch
4 times, most recently
from
c23b50f
to
e27bb5a
Compare
ipaksc
force-pushed
the
rsscors
branch
3 times, most recently
from
4c6d783
to
bf59537
Compare
src/plugins/feeds/feeds.js
Outdated
|
|
||
| if ( elm ) { | ||
| $elm = $( elm ); | ||
| $content = $( elm ).find( ".feeds-cont" ); |
There was a problem hiding this comment.
Can you replace ````$( elm )by$elm```?
w# with '#' will be ignored, and an empty message aborts the commit.
|
I updated the test site as per the latest Ilya changes. Test URL: http://universallabs.org/wet/labs/pr-8502/demos/feeds/feeds-en.html |
No description provided.