Build: Update CSSLint/banner to support #8677's changes #8679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents CSSLint errors about duplicate charset declarations in unminified CSS files.
Disables the following rules: - order-alphabetical: Warnings originating from Bootstrap's SCSS structure. - selector-max: Irrelevant error since WET no longer supports IE9 (nor 10). - selector-newline: Warnings originating from Bootstrap's SCSS selectors.
duboisp
reviewed
Jul 10, 2019
|
Dismiss my comment, I just saw your extended description in your commit message. Is those adjustment for the CSSlint is needed because of the change to Bootstrap 3.4 or because of the bumped version applied by this PR? |
duboisp
approved these changes
Jul 11, 2019
This was referenced Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8677