Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap overrides: Disable text-decoration-skip-ink on abbr[title] #8768

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Bootstrap overrides: Disable text-decoration-skip-ink on abbr[title] #8768

merged 1 commit into from
Dec 18, 2019

Conversation

EricDunsworth
Copy link
Member

Fixes #8767

@EricDunsworth
Copy link
Member Author

@duboisp @GormFrank I would highly recommend updating GCWeb's WET dependency to this commit once it gets merged in so it'll be in place the next time GCWeb gets updated on Canada.ca.

FWIW, the "GST/HST" abbreviation on https://www.canada.ca/en/services/benefits.html is affected by the bug this PR fixes. But the bug isn't showing up atm because the CSS statement that causes the bug was stripped out by Canada.ca's botched CSS minifier.

@EricDunsworth
Copy link
Member Author

I've just force-pushed an update to fix the sasslint failure.

WET's grunt-sass-lint dependency (^0.2.4) is currently up-to-date. But it doesn't recognize text-decoration-skip-ink due to sasstools/sass-lint#1281. My only option was to add a line comment with a disable rule.

@EricDunsworth EricDunsworth force-pushed the v4.0-abbr-title-text-decoration-skip-ink-none branch from 14cd451 to 14340b5 Compare November 22, 2019 19:18
@EricDunsworth
Copy link
Member Author

FYI the current Travis-CI failure has nothing to do with any of this PR's changes. I tried restarting it in case it was just a one-off, but it failed once again.

@duboisp
Copy link
Member

duboisp commented Dec 12, 2019

Pre-approved at the technical review after the comment is added

@EricDunsworth EricDunsworth force-pushed the v4.0-abbr-title-text-decoration-skip-ink-none branch from 14340b5 to 835cb16 Compare December 12, 2019 18:21
@EricDunsworth
Copy link
Member Author

@duboisp Updated :)!

@GormFrank GormFrank merged commit 0c76155 into wet-boew:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duboisp duboisp duboisp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firefox sometimes renders dotted underlines as solid underlines - which impacts abbr[title]
3 participants
@EricDunsworth @duboisp @GormFrank