Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example of "Datalist (auto complete) - Dynamic" polyfill #9065

Merged
merged 3 commits into from Apr 1, 2021
Merged

Fix example of "Datalist (auto complete) - Dynamic" polyfill #9065

merged 3 commits into from Apr 1, 2021

Conversation

k-w-1
Copy link
Contributor

@k-w-1 k-w-1 commented Mar 18, 2021

What does this pull request (PR) do? / Que fait cette demande « pull » (PR)?

Corrects documentation examples of Datalist (auto complete) - Dynamic with correct prefixes that actually return issues. The example code is AJAXing in GitHub issues, filtering against "Plugin: Multimedia player" and "Plugin: Lightbox", but it appears as though the labels today are "Feature: Multimedia player" and "Feature: Lightbox".

I realize this is a minor detail in the grand scheme of things, but as a public servant in what I assume is a common situation of trying to apply a unstoppable small force to an immovable object (i.e. the adoption of modern digital standards in my corner of the public service), these documentation pages actually end up being very useful, authoritative examples.

Additional information (optional) / Information additionnelle (optionel)

General checklist / Liste de contrôle générale
I don't actually have a true development environment setup for this kind of work and as such can't actually build the code -- but the scope of code changes is so small, this should hopefully be OK. I'm at least not so crazy to propose these changes without any supporting facts, I have included screenshots below of the JSON returned before & after the URL adjustment.

  • N/A Create/update documentation /// Créer/mettre à jour la documentation
  • See above Build and test PR's code /// Rouler le script de compilation et tester le code de la PR
  • N/A Validate changes against WCAG for accessibility /// Valider les changements avec WCAG pour l'accessibilité
  • N/A Ensure documentation is bilingual /// S'assurer que la documentation soit bilingue

Related issues / Requêtes associées
I didn't open one separately -- hopefully this is ok.

Screenshots / Captures d'écrans
URLs as used in example today (showing raw to explicitly show empty JSON response):

Before:
Incorrect URL
After:
Corrected URL

Corrects the example code
Corrects code by updating AJAX URL with correct GitHub issue prefix (was "Plugin: ", now "Feature: ")
Correct French example code
@GormFrank GormFrank merged commit 4876117 into wet-boew:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants