Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested control: NEW plugin to nest field within checkbox/radio #9316

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GormFrank
Copy link
Contributor

@GormFrank GormFrank commented Mar 29, 2022

What does this pull request (PR) do?

Provide ability to have a nested field within a checkbox or radio form control.

Additional information

General checklist / Liste de contrôle générale

  • Translate documentation to French
  • Validate changes against WCAG for accessibility and test for screen readers
  • Test against other checkbox and radio button list patterns (may collide with GC-Chckbxrdio in GCweb)
  • Define limitations

@GormFrank
Copy link
Contributor Author

Up here for testing purposes: https://universallabs.org/wet/labs/pr-9316/demos/nested-control/nested-control-en.html

@duboisp
Copy link
Member

duboisp commented Apr 20, 2022

In the working example, the first bullet items are right aligned instead of left aligned.

@EricDunsworth
Copy link
Member

FWIW it looks like it's only happening in Firefox. I checked the Universal labs demo in Edge Chromium earlier and it looked ok in that browser.

Seems similar to #9147 but with a different root cause.

@EricDunsworth
Copy link
Member

If this PR ultimately leads to anything viable (i.e. a stable feature - not a provisional "use at your own risk" class or plugin :P), it might be worth modifying the OP or commit message to make it close #8836.

IMO this PR's code is much simpler and more elegant than what @fsnoddy and I proposed in #8836. But it lacks aria-* attributes (some of which would've been brought in by the toggle plugin if #8836 had been finalized).

More research and testing will probably be needed to figure out how best to leverage aria-* attributes in the scenario this PR addresses. For instance, could you get away with just aria-live? Would aria-controls be a better bet, or would screen readers not care about in practice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants