-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ESLint version & rules, then fix code across project, and fixed #212 #213
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7b56930
Set .eslintrc to show lint warning/error
haxpor e9be6e4
Merge branch 'fix_eslint'
haxpor 08e50f4
Update ESLint v. and its rules and fix warnings/errors across project
haxpor 96c831b
Merge branch 'update_eslint'
haxpor d38636c
Fix issue 212
haxpor a5757f2
Merge branch 'fix_#212'
haxpor b0ba6d1
Review and fix #212 with better approach
haxpor ec45e68
Merge branch 'fix_#212'
haxpor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haxpor Thanks for the PR and work to the lint!
I believe to use Link in this case will require dependency from react-router and not everyone use react-router as router even though most of the single page application do.
Can you modify it to something like Cell that people will be able to pass into their component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree! That's much more robust.
I've fixed it to provide
component
property to be set in Grid as similar toCell
class.