Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

badgooooor/#40 Legistration process page -- overview section #51

Merged
merged 10 commits into from
Oct 30, 2023
Merged

badgooooor/#40 Legistration process page -- overview section #51

merged 10 commits into from
Oct 30, 2023

Conversation

badgooooor
Copy link
Contributor

@badgooooor badgooooor commented Oct 22, 2023 •
edited

Description

  • From Legislative process content 1/9: Overview #40
  • Add content in legistration process page -- overview section
  • Note: I have a bit problem on exporting and optimize process images (the 3 steps one) that there is still some white background leaked to image. I've tried on both squoosh.app or ImageOptim and they didn't remove it 😢.

Desktop
image
image

Mobile
image
image

@badgooooor badgooooor mentioned this pull request Oct 23, 2023
Merged
Th1nkK1D
Th1nkK1D requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Th1nkK1D Th1nkK1D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some comments. I also found an image issue. I will talk with the designer and get back to you since it is not correct when exporting from Figma. Image optimizer just compresses the image to have a smaller size so it won't help.

src/components/LegislativeProcess/ProcessCard.svelte Outdated Show resolved Hide resolved
src/routes/legislative-process/+page.svelte Show resolved Hide resolved
src/routes/legislative-process/+page.svelte Show resolved Hide resolved
@badgooooor
Copy link
Contributor Author

Thanks for the PR! I left some comments. I also found an image issue. I will talk with the designer and get back to you since it is not correct when exporting from Figma. Image optimizer just compresses the image to have a smaller size so it won't help.

Please ping me if images are updated. I'll retry exporting it.

@Th1nkK1D
Copy link
Contributor

Please ping me if images are updated. I'll retry exporting it.

Our designers fix it. Please try to export the images again.

@badgooooor
Copy link
Contributor Author

Updated images.

image image

@Th1nkK1D
Copy link
Contributor

LGTM! Thank you for another PR ;)

@Th1nkK1D Th1nkK1D merged commit 7ad4408 into wevisdemo:main Oct 30, 2023
@Th1nkK1D Th1nkK1D mentioned this pull request Oct 30, 2023
Closed
svnnynior pushed a commit to svnnynior/parliament-watch that referenced this pull request Nov 17, 2023
@badgooooor
feat(wevisdemo#40): add overview section in legistration process page (…
aa4f270 
…wevisdemo#51)

* feat(wevisdemo#40): add text content session

* feat(wevisdemo#40): add image process

* feat(wevisdemo#40): add process card section

* feat(wevisdemo#40): add scope of law in website section

* fix(wevisdemo#40): fix arrow layout in process grid

* fix(wevisdemo#40): fix list layout

* fix(wevisdemo#40): refactor img alt

* fix(wevisdemo#40): paragraph indention

* refactor(wevisdemo#40): refactor img alt

* feat(wevisdemo#40): update image assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th1nkK1D Th1nkK1D Th1nkK1D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@badgooooor @Th1nkK1D