Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: request url no forwarded host #256

Merged
merged 4 commits into from
Apr 14, 2024
Merged

fix: request url no forwarded host #256

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3fae92d
fix: don't delete port if there is no forwarded host
dalechyn Apr 14, 2024
20fc942
chore: changesets
dalechyn Apr 14, 2024
aec9dde
chore: better changeset
dalechyn Apr 14, 2024
5215f28
chore: better changeset
dalechyn Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/modern-baboons-build.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this changeset more concise?

i.e. “Fixed a regression where…”

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"frog": patch
---

Fixed a regression in local environment where port was deleted from the generated metadata `postUrl` and `image` tags that resulted in incorrect links when `X-Forwarded-Host` header value is `localhost`.
dalechyn marked this conversation as resolved.
Show resolved Hide resolved
3 changes: 2 additions & 1 deletion src/utils/getRequestUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export function getRequestUrl(req: Context['req']) {
const forwardedHost = req.header('x-forwarded-host')
url.host = forwardedHost ?? url.host
url.protocol = req.header('x-forwarded-proto') ?? url.protocol
if (!forwardedHost?.startsWith('localhost')) url.port = ''
if (forwardedHost !== undefined && !forwardedHost.startsWith('localhost'))
url.port = ''
return url
}
Loading