Update parseImage.ts #329
Closed
Update parseImage.ts #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@vikiival is attempting to deploy a commit to the wevm Team on Vercel. A member of the Team first needs to authorize it. |
dalechyn
reviewed
May 21, 2024
Comment on lines
+57
to
+58
| const isPath = typeof src === 'string' && src.startsWith('/') | ||
| if (isPath) node.props.src = `${assetsUrl + parsePath(src)}` |
There was a problem hiding this comment.
i don't think that anything other than string is expected here.
dalechyn
reviewed
May 21, 2024
|
closing this as stale. please consider reopening if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Back in Feb 2024 I was able to use arraybuffer a image src
Now I am getting this fancy error
Fix
Skip
src.startsWithwhen it is not a string