Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: up max blobs #1995

Merged
merged 2 commits into from
Mar 21, 2024
Merged

feat: up max blobs #1995

merged 2 commits into from
Mar 21, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Mar 21, 2024

supersedes #1991


PR-Codex overview

This PR increases the blobs limit to 6 per transaction and adjusts the test data size in toBlobs.test.ts to align with the new limit.

Detailed summary

  • Updated blobsPerTransaction limit to 6 in blob.ts
  • Adjusted test data size in toBlobs.test.ts to match the new limit

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Mar 21, 2024

🦋 Changeset detected

Latest commit: e641ca1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Mar 21, 2024 10:35pm

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 66.34 KB (0%) 1.4 s (0%) 6 s (+259.45% 🔺) 7.4 s
viem (cjs) 86.18 KB (-0.01% 🔽) 1.8 s (-0.01% 🔽) 5 s (-34.15% 🔽) 6.7 s
viem (minimal surface - tree-shaking) 3.72 KB (0%) 75 ms (0%) 57 ms (-65.96% 🔽) 131 ms
viem/accounts 91.47 KB (0%) 1.9 s (0%) 2.1 s (+63.14% 🔺) 4 s
viem/accounts (tree-shaking) 21.09 KB (0%) 422 ms (0%) 560 ms (-68.49% 🔽) 981 ms
viem/actions 46.67 KB (0%) 934 ms (0%) 1.8 s (+159.71% 🔺) 2.7 s
viem/actions (tree-shaking) 340 B (0%) 10 ms (0%) 34 ms (+5.23% 🔺) 44 ms
viem/chains 29.97 KB (0%) 600 ms (0%) 924 ms (+44.41% 🔺) 1.6 s
viem/chains (tree-shaking) 367 B (0%) 10 ms (0%) 24 ms (-6.64% 🔽) 34 ms
viem/chains/utils 1.16 KB (0%) 24 ms (0%) 31 ms (-5.73% 🔽) 54 ms
viem/ens 46.67 KB (0%) 934 ms (0%) 1.4 s (+154.25% 🔺) 2.4 s
viem/ens (tree-shaking) 20.68 KB (0%) 414 ms (0%) 1.1 s (+11.07% 🔺) 1.5 s

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (4f7a6b1) to head (e641ca1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1995      +/-   ##
==========================================
- Coverage   99.77%   99.76%   -0.01%     
==========================================
  Files         578      578              
  Lines       50827    50827              
  Branches     2529     2528       -1     
==========================================
- Hits        50714    50710       -4     
- Misses        100      103       +3     
- Partials       13       14       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxom jxom merged commit 0cf4170 into main Mar 21, 2024
27 of 29 checks passed
@jxom jxom deleted the jxom/up-max-blobs branch March 21, 2024 22:38
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
@tmm tmm mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant