Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolves #2055 #2063

Merged
merged 3 commits into from
Apr 3, 2024
Merged

fix: resolves #2055 #2063

merged 3 commits into from
Apr 3, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Apr 3, 2024

restricts transaction request args – fixes #2055


PR-Codex overview

This PR fixes redundant properties in the transactionRequest formatter and updates gas estimation request bodies.

Detailed summary

  • Fixed redundant properties issue in the transactionRequest formatter
  • Updated gas estimation request bodies in multiple test files

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: 6a49e86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Apr 3, 2024 8:19pm

Copy link
Contributor

github-actions bot commented Apr 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 66.52 KB (+0.08% 🔺) 1.4 s (+0.08% 🔺) 258 ms (-29.85% 🔽) 1.6 s
viem (cjs) 86.38 KB (+0.05% 🔺) 1.8 s (+0.05% 🔺) 948 ms (+92.92% 🔺) 2.7 s
viem (minimal surface - tree-shaking) 3.76 KB (0%) 76 ms (0%) 27 ms (+96.98% 🔺) 102 ms
viem/accounts 91.48 KB (0%) 1.9 s (0%) 160 ms (+43.26% 🔺) 2 s
viem/accounts (tree-shaking) 21.1 KB (0%) 423 ms (0%) 153 ms (+313.19% 🔺) 575 ms
viem/actions 46.71 KB (+0.06% 🔺) 935 ms (+0.06% 🔺) 69 ms (-43.69% 🔽) 1.1 s
viem/actions (tree-shaking) 340 B (0%) 10 ms (0%) 25 ms (+871.15% 🔺) 35 ms
viem/chains 30.98 KB (+0.11% 🔺) 620 ms (+0.11% 🔺) 189 ms (+43.39% 🔺) 808 ms
viem/chains (tree-shaking) 367 B (0%) 10 ms (0%) 3 ms (+10.45% 🔺) 13 ms
viem/chains/utils 1.16 KB (0%) 24 ms (0%) 4 ms (+37.55% 🔺) 27 ms
viem/ens 46.71 KB (+0.06% 🔺) 935 ms (+0.06% 🔺) 87 ms (-30.16% 🔽) 1.1 s
viem/ens (tree-shaking) 20.73 KB (+0.16% 🔺) 415 ms (+0.16% 🔺) 90 ms (+81.98% 🔺) 505 ms

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 99.72%. Comparing base (0309572) to head (9043c4a).

❗ Current head 9043c4a differs from pull request most recent head 6a49e86. Consider uploading reports for the commit 6a49e86 to get more accurate results

Files Patch % Lines
src/utils/formatters/transactionRequest.ts 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
- Coverage   99.73%   99.72%   -0.02%     
==========================================
  Files         604      604              
  Lines       54802    54809       +7     
  Branches     2620     2624       +4     
==========================================
- Hits        54659    54658       -1     
- Misses        129      136       +7     
- Partials       14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxom jxom merged commit f539b0d into main Apr 3, 2024
20 of 27 checks passed
@jxom jxom deleted the fix-2055 branch April 3, 2024 20:26
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Unable to send any Celo transactions
1 participant