fix: properly manage RFC 3986 authority domain check
#2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## PR overview Using the current regex expression only second level domains are accepted. However, that is not the way it is specified on RFC 3986. With the current implementation for instance all country code second-level domains (ccSLD) like domain.co.uk are not accepted. The fix allows multi-level domains. ### Detailed summary Changed `domainRegex` regex to allow multiple level domains.
|
@agsola is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 17fa3b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Please add a changeset with |
I've not used |
1 task
davisshaver
reviewed
Jun 3, 2024
tmm
reviewed
Jun 3, 2024
Co-authored-by: awkweb <tom@meagher.co>
tmm
approved these changes
Jun 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR overview
Using the current regex expression only second level domains are accepted. However, that is not the way it is specified on
RFC 3986.With the current implementation for instance all domains using
country code second-level domains (ccSLD)like domain.co.uk are not accepted (as they are third-level domains).The fix allows multi-level domains.
Detailed summary
Changed
domainRegexregex var to allow multiple level domains.PR-Codex overview
This PR focuses on fixing the
createSiweMessagedomain check to comply with RFC 3986.Detailed summary
domainRegexto be RFC 3986 compliantcreateSiweMessagewith valid domain inputs