domainRegex used for SIWE domain validation should match subdomains

[davisshaver]

Check existing issues

• I checked there isn't already an issue for the bug I encountered.

Viem Version

2.13.3

Current Behavior

Subdomains do not currently match the domain regex used for validating SIWE messages.

Example interactive regex: regexr.com/816ai

Expected Behavior

As far as I can tell, subdomains are compliant with RFC 3986 and should match the regex used for validating domains. Subdomains worked with previous implementations of SIWE such as the siwe package.

Steps To Reproduce

No response

Link to Minimal Reproducible Example

https://wp-rainbow.davisshaver.com/2022/03/24/hello-world/

Anything else?

[tmm]

This should take care of that

#2351

[davisshaver]

@tmm Looks like it should, here's a RegExr link which shows the domain validating with the updated regex

[github-actions]

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Viem version. If you have any questions or comments you can create a new discussion thread.