fix: remove unneeded uniqueBy check

wevm · Mar 29, 2024 · b80236d · b80236d
1 parent d2c8c32
commit b80236d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 17 deletions.
diff --git a/.changeset/smart-dots-walk.md b/.changeset/smart-dots-walk.md
@@ -0,0 +1,6 @@
+---
+"@wagmi/core": patch
+"wagmi": patch
+---
+
+Removed unneeded `uniqueBy` check on connectors state.
diff --git a/packages/core/src/createConfig.ts b/packages/core/src/createConfig.ts
@@ -24,7 +24,6 @@ import { type Storage, createStorage, noopStorage } from './createStorage.js'
 import { ChainNotConfiguredError } from './errors/config.js'
 import type { Evaluate, ExactPartial, LooseOmit, OneOf } from './types/utils.js'
 import { uid } from './utils/uid.js'
-import { uniqueBy } from './utils/uniqueBy.js'
 import { version } from './version.js'
 
 export type CreateConfigParameters<
@@ -286,7 +285,7 @@ export function createConfig<
     }
 
     if (parameters.storage && !store.persist.hasHydrated()) return
-    connectors.setState((x) => uniqueBy([...x, ...newConnectors], 'id'), true)
+    connectors.setState((x) => [...x, ...newConnectors], true)
   })
 
   /////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/packages/core/src/hydrate.ts b/packages/core/src/hydrate.ts
@@ -1,6 +1,5 @@
 import { reconnect } from './actions/reconnect.js'
 import type { Config, State } from './createConfig.js'
-import { uniqueBy } from './utils/uniqueBy.js'
 
 type HydrateParameters = {
   initialState?: State | undefined
@@ -25,9 +24,10 @@ export function hydrate(config: Config, parameters: HydrateParameters) {
           ?.getProviders()
           .map(config._internal.connectors.providerDetailToConnector)
           .map(config._internal.connectors.setup)
-        config._internal.connectors.setState((connectors) =>
-          uniqueBy([...connectors, ...(mipdConnectors ?? [])], 'id'),
-        )
+        config._internal.connectors.setState((connectors) => [
+          ...connectors,
+          ...(mipdConnectors ?? []),
+        ])
       }
 
       if (reconnectOnMount) reconnect(config)

diff --git a/packages/core/src/utils/uniqueBy.ts b/packages/core/src/utils/uniqueBy.ts