Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove chainId param from Viem readContract calls #3443

Merged
merged 5 commits into from
Jan 14, 2024

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Jan 13, 2024

Description

Remove chainId parameter from readContract calls in wagmi core action
Fixes #3442

Additional Information

Before submitting this issue, please make sure you do the following.

  • Read the contributing guide
  • Added documentation related to the changes made.
  • Added or updated tests (and snapshots) related to the changes made.

Copy link

changeset-bot bot commented Jan 13, 2024

🦋 Changeset detected

Latest commit: 06ee2b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@wagmi/connectors Patch
create-wagmi Patch
wagmi Patch
@wagmi/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ❌ Failed (Inspect) Jan 13, 2024 11:15pm

Copy link

vercel bot commented Jan 13, 2024

@jmrossy is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@tmm tmm merged commit 007024a into wevm:main Jan 14, 2024
4 of 9 checks passed
@jmrossy jmrossy deleted the read-contract-param-fix branch January 15, 2024 01:23
plusminushalf added a commit to plusminushalf/wagmi that referenced this pull request Jan 18, 2024
* Remove chainId param from viem readContract calls

* Add changeset

* Undo import reordering

* chore: up

* chore: changeset

---------

Co-authored-by: Tom Meagher <tom@meagher.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Celo compatibility broken in Wagmi V2
2 participants