-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: connector listeners #3788
Conversation
🦋 Changeset detectedLatest commit: 9e85736 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -191,7 +191,7 @@ export function createConfig< | |||
function getInitialState() { | |||
return { | |||
chainId: chains.getState()[0].id, | |||
connections: new Map(), | |||
connections: new Map<string, Connection>(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improve types
if (connector.emitter.listenerCount('connect')) | ||
connector.emitter.off('connect', change) | ||
if (!connector.emitter.listenerCount('change')) | ||
connector.emitter.on('change', change) | ||
if (!connector.emitter.listenerCount('disconnect')) | ||
connector.emitter.on('disconnect', disconnect) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'connect'
event should bind connector emitter similar to how the connect
action does, allowing connectors to connect via wallet interfaces (e.g. MetaMask "unlock").
Size Change: +742 B (0%) Total Size: 618 kB
ℹ️ View Unchanged
|
// We shouldn't need to listen for `'accountsChanged'` here since the `'connect'` event should suffice (and wallet shouldn't be connected yet). | ||
// Some wallets, like MetaMask, do not implement the `'connect'` event and overload `'accountsChanged'` instead. | ||
if (!accountsChanged) { | ||
accountsChanged = this.onAccountsChanged.bind(this) | ||
provider.on('accountsChanged', accountsChanged) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enables MetaMask "unlock" to connect
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Once #3787 makes it in, can do the same for the |
Description
Additional Information
Before submitting this issue, please make sure you do the following.