-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update metamask sdk #3848
Conversation
🦋 Changeset detectedLatest commit: 8d99eff The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Size Change: +5.57 kB (+1%) Total Size: 623 kB
ℹ️ View Unchanged
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/connectors/src/metaMask.ts
Outdated
| 'readonlyRPCMap' | ||
> | ||
> | ||
Omit<MetaMaskSDKOptions, '_source' | 'readonlyRPCMap'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make dappMetadata
optional and default to {}
? Since the following is valid.
const connectorFn = metaMask({
dappMetadata: {},
})
That way you can get started with the connector faster:
const connectorFn = metaMask()
packages/connectors/src/metaMask.ts
Outdated
localStorage.removeItem('MMSDK_cached_address') | ||
localStorage.removeItem('MMSDK_cached_chainId') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localStorage
might not be defined
Description
Updated MetaMask SDK to
0.18.5
.Additional Information
Before submitting this issue, please make sure you do the following.