feat: update metamask sdk #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8d99eff The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
This was referenced Apr 24, 2024
|
Size Change: +5.57 kB (+1%) Total Size: 623 kB
ℹ️ View Unchanged
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmm
reviewed
Apr 24, 2024
packages/connectors/src/metaMask.ts
Outdated
| | 'readonlyRPCMap' | ||
| > | ||
| > | ||
| Omit<MetaMaskSDKOptions, '_source' | 'readonlyRPCMap'> |
There was a problem hiding this comment.
Can we make dappMetadata optional and default to {}? Since the following is valid.
const connectorFn = metaMask({
dappMetadata: {},
})That way you can get started with the connector faster:
const connectorFn = metaMask()
tmm
reviewed
Apr 24, 2024
packages/connectors/src/metaMask.ts
Outdated
Comment on lines
279
to
280
| localStorage.removeItem('MMSDK_cached_address') | ||
| localStorage.removeItem('MMSDK_cached_chainId') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated MetaMask SDK to
0.18.5.Additional Information
Before submitting this issue, please make sure you do the following.