Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to Ballot link should specify the election or ballot returned #1596

Closed
DaleMcGrew opened this issue Jul 2, 2018 · 1 comment
Closed
Assignees
Labels
Difficulty: High For advanced engineers Priority: 2

Comments

@DaleMcGrew
Copy link
Member

Please describe the issue (What happens? What do you expect?)

If I send a candidate link to a friend, the "Back to Ballot" link should take me to the election that the candidate is in, and it doesn't currently.

Steps to reproduce the problem (1, 2, 3...), including links

  1. On WeVote.US choose any election except Alabama
  2. Go to this candidate in the Alabama race: https://wevote.us/candidate/wv02cand33006/b/btdb/
  3. The Back to ballot takes you to the non-Alabama race, and it should.
    Solution: When you are on a candidate page with "/b/btdb/" (back to default ballot) at the end, make the "Back to Ballot" button take the voter to this url (with the "1111" as the google_civic_election_id): /ballot/election/1111
    OR /ballot/id/:ballot_returned_we_vote_id

If you are on a candidate page with "/btvg/" (back to voter guide) like this: https://wevote.us/candidate/wv02cand30772/btvg/wv02org145
...then take them back to:
/voterguide/:organization_we_vote_id/ballot/election/:google_civic_election_id
OR /voterguide/:organization_we_vote_id/ballot/id/:ballot_returned_we_vote_id

@DaleMcGrew DaleMcGrew added Priority: 2 Difficulty: High For advanced engineers labels Jul 2, 2018
lazorfuzz added a commit to lazorfuzz/WebApp that referenced this issue Jan 30, 2019
* Fixed bug with voter guide page crashing when clicking "All Positions" 
or "Listening To"

* Converted VoterGuideStore to camel case

* Got a start on camel case conversions in VoterStore
DaleMcGrew added a commit that referenced this issue Jan 30, 2019
[Issue #1596] Fix back to ballot button route
@DaleMcGrew
Copy link
Member Author

Excellent work @lazorfuzz! Verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: High For advanced engineers Priority: 2
Projects
None yet
Development

No branches or pull requests

2 participants