Headers get placed on messages even if no value for the header is set. #221
Labels
bug
Something isn't working
Comments
rhinof
pushed a commit
that referenced
this issue
Nov 9, 2019
rhinof
pushed a commit
that referenced
this issue
Nov 10, 2019
* only sending headers over the wire if they contain a value fixing #221 * deleting file that was added by mistake
rhinof
pushed a commit
that referenced
this issue
Dec 2, 2019
* only sending headers over the wire if they contain a value fixing #221 * deleting file that was added by mistake
vladshub
pushed a commit
that referenced
this issue
Dec 2, 2019
* added reply to initiator functionality to sagas (#157) * added generic handler metrics with message type as the label (#144) * added generic handler metrics with message type as the label * add handler name label to the metrics * adding new metrics to the read me * Fix handle empty body (#156) * fixing ReplyToInitiator not working when initiator sends a message via the RPC interface (#163) * fixing ReplyToInitiator not working when initiator sends a message via the RPC interface * Improved wording of saga documentation article (#164) * better wording for documentation * added golangcli lint configuration and fixed linting failures (#165) * Fix logging and added logging documentation (#176) * fixed logging issues and added documentation logging via the invocation interface was broken and did not add contextual data related to the invocation due to a bug in the way the Glogged structure is currently implemented. Also added documentation on how logging should be done within a handler including adding context to returned errors so that data gets logged * added missing documentation file * added documentation on serialization support (#177) * fixed emperror url format * added serialization documentation * added documentation for messaging patterns, retries and transactional processing (#181) * fixed emperror url format * added serialization documentation * added documentation for message semantics, retries and transactions * Added sample application (#184) * fixing minor tech debt issues (#199) * fix(bug:200) logs are now being reported correctly Fixes issue #200 Also updated go.mod for newer versions of dependancies * fix wrongly set correlation ids when sending a command (#220) * adding the SagaCorrelationID header only for replies Fixing a bug where grabbit would set the message.CorrelationID and the message.SagaCorrelationID header even if the message was a command and not a reply. * fixing minor documentation issue * only sending headers over the wire if they contain a value (#222) * only sending headers over the wire if they contain a value fixing #221 * deleting file that was added by mistake * goodbye (#223) * goodbye * Fixing my last bug :) * Add saga latency metric (#224) records the execution time of the entire saga, from it's creation until deletion (in ms). having the "Service", "SagaType", "Initiator" as labels|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some headers such as x-msg-saga-id, x-msg-saga-correlation-id and x-grabbit-msg-rpc-id should only be set in specific contexts.
if no value for these headers exist in a context then these headers should not be sent over the wire as it might create incompatibilities with clients that can distinguish between null/nil to empty strings
The text was updated successfully, but these errors were encountered: