fixing a bug in which all handler retires executed within the same #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transaction When a handler fails and gets retried each retry should be run in a new transaction
vladshub
suggested changes
Jun 5, 2019
| _ = worker.ack(delivery) | ||
| } | ||
| //else there was an error in the invokation then try rollingback the transaction and reject the message | ||
| _ = worker.ack(delivery) |
There was a problem hiding this comment.
Why are you ignoring the error?
There was a problem hiding this comment.
after examining the code of worker.ack (and worker.nack) the retry strategy defined there retries the action until it succeeds (returns no error) in 100ms intervals
There was a problem hiding this comment.
then we should fix the function . not to return an error but it would be a whole different PR.
There was a problem hiding this comment.
yes, will do it in a diff PR
| worker.log().WithError(rbkErr).Error("failed rolling back transaction when recovering from handler error") | ||
| } | ||
| } | ||
| return handlerErr |
|
|
vladshub
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transaction
When a handler fails and gets retried each retry should be run in a new
transaction
Closes #81