added test to accept if summary is nonexistent

wework · Mar 29, 2018 · a717a53 · a717a53
1 parent b132edc
commit a717a53
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 23 deletions.
diff --git a/lib/linter.js b/lib/linter.js
@@ -148,14 +148,6 @@ const lint = (objectName, object, options = {}) => {
                     });
                 }
             }
-            if (rule.exists) {
-                const { value, property } = rule.exists;
-                if (object[property]) {
-                  ensure(rule, () => {
-                    object[property].should.not.exist(value);
-                  })
-                }
-            }
         }
     }
 }

diff --git a/test/linter.test.js b/test/linter.test.js
@@ -118,28 +118,19 @@ describe('linter.js', () => {
                     done();
                 });
 
+                it('is fine if there is no summary', done => {
+                    const input = { foo: '123'};
+                    lintAndExpectValid(rule, input);
+                    done();
+                });
+
                 it('errors when string is too long', done => {
                     const input = { summary: '123456' };
                     lintAndExpectErrors(rule, input, ['gotta-be-five']);
                     done();
                 });
             });
 
-            context('exists', () => {
-                const rule = {
-                  "name": "exists",
-                  "object": "*",
-                  "enabled": true,
-                  "exists": { "property": "summary", "value": null }
-                };
-
-                it('accepts when value is nonexistent', done => {
-                  const input = { summary: null };
-                  lintAndExpectValid(rule, input);
-                  done();
-                })
-            });
-
             context('pattern', () => {
                 context('when split and omit arguments are used', () => {
                     const rule = {