Use nyc to allow coverage of es6 syntax #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
commented
Mar 21, 2018
| @@ -1,70 +1,69 @@ | |||
| { | |||
| "name": "speccy", | |||
There was a problem hiding this comment.
Bah, sorry. Indentation was inconsistent and broken, and my editor decided to "fix it".
Only lines changed were:
- "test": "mocha",
- "cover": "istanbul cover _mocha",
- "coveralls": "npm run cover -- --report lcovonly -- -R spec && cat ./coverage/lcov.info | coveralls"
+ "test": "nyc --reporter=html --reporter=text mocha",
+ "coverage": "nyc report --reporter=text-lcov | coveralls"
Also swapped out the old "istanbul" for "nyc".
dangoosby
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapped istanbul for nyc, which is newer and supports ES6 syntax. This will stop coveralls simply ignoring any files like
lib/loader.jswhich contain syntax it's not happy about.