Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permute_any_mods output is not recognized by wezterm (in nightly) #3434

Closed
eugenesvk opened this issue Apr 3, 2023 · 3 comments
Closed

permute_any_mods output is not recognized by wezterm (in nightly) #3434

eugenesvk opened this issue Apr 3, 2023 · 3 comments
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@eugenesvk
Copy link
Contributor

What Operating System(s) are you seeing this problem on?

macOS

Which Wayland compositor or X11 Window manager(s) are you using?

none

WezTerm version

wezterm 20230402-190554-d25dbdd8

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

I get an error that implies wezterm doesn't understand the modifier that are produced by the permute_any_mods function

Error

Configuration Error: Error converting lua value returned by script wezterm.lua to Config struct: error converting Lua table to config::config::Config (Error processing mouse_bindings.mods.mods (types: Config, Mouse, MouseEventTriggerMods) invalid modifier name Modifiers(NONE in Modifiers(NONE | SUPER))

To Reproduce

Replace your config with the one below and launch wezterm

Configuration

local wezterm = require 'wezterm'

return {
  mouse_bindings = {
    table.unpack(wezterm.permute_any_mods {
      event = { Down = { streak = 1, button = 'Middle' } },
      action = 'PastePrimarySelection',
    }),
  },
}

Expected Behavior

permute_any_mods to work like before

Logs

No response

Anything else?

No response

@eugenesvk eugenesvk added the bug Something isn't working label Apr 3, 2023
wez added a commit that referenced this issue Apr 3, 2023
The termwiz Modifiers type isn't the right one!
Use the input layer types instead, and then we get the correct
string formatting.

refs: #3434
@wez
Copy link
Owner

wez commented Apr 3, 2023

This should be resolved now in main.

It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Apr 3, 2023
@eugenesvk
Copy link
Contributor Author

Thanks for a very prompt fix!

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

2 participants