Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error outputting 24 bit color gradients #785

Closed
splitDEV opened this issue May 11, 2021 · 3 comments
Closed

Error outputting 24 bit color gradients #785

splitDEV opened this issue May 11, 2021 · 3 comments
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@splitDEV
Copy link

Describe the bug

I stumbled upon wezterm and I really like it so far. Thank you for your work and time.
I tried some things and unfortunately displaying 24 bit color gradients resulted in nothing being shown, despite true color support seems to be working for normal text output using escape sequences:

Working 24 bit

Environment

  • OS: Archlinux
  • Version: wezterm 20210502-154244-3f7122cb
  • ENG

To Reproduce

Run the following script in wezterm: https://github.com/csdvrx/sixel-testsuite/blob/master/24-bit-color.sh

Configuration

--

Expected behavior

Left terminal wezterm, right terminal kitty:

Ouptut from wezterm and kitty

@splitDEV splitDEV added the bug Something isn't working label May 11, 2021
@wez
Copy link
Owner

wez commented May 12, 2021

That script uses a non-standard encoding for true color. There's a complicated back story, but it boils down to
a sequence such as ^[38;2;<r>;<g>;<b>m (where the 2 is the rgb color space, and the values are semicolon separated) as being the standard. Some terminals mis-implemented that using : for a separator, and then again an implementation of that which omits the 2 (color space) parameter is floating out there.

The script is using SEPARATOR=: even though its comments use ; at the top of the script.
If you change the script to set SEPARATOR=; on this line https://github.com/csdvrx/sixel-testsuite/blob/master/24-bit-color.sh#L11 it will render the color sequence correctly.

I've pushed 3d83a80 which also allows recognizing the sequence used in that script.

@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label May 12, 2021
@wez wez closed this as completed in 3c6fb77 May 12, 2021
@splitDEV
Copy link
Author

Wow thank you for the quick response and fix :)

You're doing outstanding work!!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

2 participants