Linear gradient #2038
Merged
Linear gradient #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wez
reviewed
May 26, 2022
There was a problem hiding this comment.
This looks good, thank you!
I think the angle should be specified in degrees in the config, as that is more of a lay-person's unit, and is easier to intuit what a given degree value means than the equivalent in radians!
regarding the name Directional, what do you think about maybe renaming it to Linear?
That feels closer to the CSS equivalent: https://developer.mozilla.org/en-US/docs/web/css/gradient/linear-gradient
|
I agree. Will fix :) |
|
Renamed to |
wez
reviewed
May 26, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new Directional gradient as suggested in #2023. I've also included a example to the window_background_gradient.md.
It's a linear gradient which can be rotated around the window center. Using radians per now. Should i change this to degrees?
You should now be able to add diagonal (or similar) gradients like in this example.
Here's the screenshot I've used in the example:
This is my first time using Rust, but the other examples made it quite easy to implement. Suggestions are welcomed.