link against system libraries when WEZRERM_SYSDEPS envvar is set to 1 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I've been going back and forth on whether to take this PR, but ultimately: it is important for wezterm to control the freetype and harfbuzz builds because there is a lot of variance in the versions available and their build options. 11b7982 resolves what I think was the main pain point in your original issue by adding the submodule sources into a source tarball and including that on the releases page. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #46, this patch makes it possible to use system libraries instead.
I don't know how well this will work on different distributions but it works on Arch, and freetype2 (and related) API should be stable enough.