Fix spawning new tabs/windows in directory with urlunsafe paths #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wez
requested changes
May 15, 2021
wezterm-gui/src/termwindow/spawn.rs
Outdated
| let path = url.path().to_string(); | ||
| let path = percent_decode_str(url.path()) | ||
| .decode_utf8() | ||
| .unwrap() |
There was a problem hiding this comment.
We can't tolerate an unwrap here; it will kill everything that the user is doing if a program has set a bogus cwd.
A failure to decode to utf8 should result in the path being treated as None.
There's a similar section of code over there that should also have the same treatment:
https://github.com/wez/wezterm/blob/main/wezterm-mux-server-impl/src/sessionhandler.rs#L615
The CWD is internally stored as URL. The path component is therefore stored percent_encoded. It must be decoded before use.
Arvedui
force-pushed
the
fix_urlunsafe_dir
branch
from
4c65849
to
aae01ff
Compare
|
Thanks for your feedback. Changed the patch accordingly. I did not test the changes in sessionhandler.rs though, because it is not clear to me how to do that. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CWD is internally stored as URL. The path component is therefore stored percent_encoded. It must be decoded before use.