-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a keybind to open current file in editor #313
Conversation
Signed-off-by: Wenxuan Zhang <wenxuangm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea, this could massively improve my workflow! I've requested a minor improvement though.
Co-authored-by: sandr01d <88739791+sandr01d@users.noreply.github.com>
Done. |
@wfxr Great addition, works for me! @sandr01d Great idea as well! However, refreshing does not work correctly for me. For some reason, the fzf screen is not fully redrawn after quitting the editor, so that I get a mixture of shell promts and fzf. Any idea why this might be the case? And some further idea: consider you edit the file and revert all the changes, then the file should not appear in the fzf dialog at all afterwards. Maybe this can be achieved with the |
@carlfriedrich Press
I tried and couldn't find a way to get reload() action to work for this purpose. Maybe we can improve it in a future pr? EDIT I have changed my mind, and tend to keep the file list as fzf started, even if changes on a specified file are reverted. This gives us the opportunity to select and edit it again easily. So IMO @sandr01d's |
@carlfriedrich I can not reproduce this. Does this happen only with the
I definitively see the use case here. Might be a bit confusing for some users though. Maybe we could be transparent about it and indicate that the file has no changes anymore in the preview, similar as we do here: |
@sandr01d It actually happens with and without it, so adding it is good in either way.
@wfxr That works indeed, thanks for the hint!
I see your point and agree with you. |
Signed-off-by: Wenxuan Zhang <wenxuangm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wfxr Great, approved!
Check list
Description
Add a keybind
alt-e
to allow open current file in default editor. This will facilitate doing diff and modify loop.Type of change
Test environment