Move fzf options into $opts variables #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_forgit_stash_push, _forgit_revert_commit and _forgit_blame passed some fzf options as arguments directly instead of defining them in the $opts variable, as we do everywhere else. This change makes these functions consistent with the rest of the code base and additionally allows overriding said options with the respective $FORGIT_*_FZF_OPTS environment variables.
cjappl
approved these changes
Apr 13, 2024
wfxr
approved these changes
Apr 14, 2024
carlfriedrich
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Description
_forgit_stash_push,_forgit_revert_commitand_forgit_blamepassed some fzf options as arguments directly instead of defining them in the$optsvariable, as we do everywhere else. This change makes these functions consistent with the rest of the code base and additionally allows overriding said options with the respective$FORGIT_*_FZF_OPTSenvironment variables.Type of change
Test environment