-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video reference -- feature request #344
Comments
This is a good idea. I had thought about this as well, I'm not sure if there is already an issue for this, probably not. The only thing left to do is to think on how to manage new video submissions so that we're not rickrolled or worse, but besides that, this is definitely something we should implement |
You have to use a serious source of exercise video like bodybuilding.com, take a look at this http://www.bodybuilding.com/exercises/detail/view/name/barbell-full-squat There you have not only video but real pictures. You cannot relay on YouTube such the link provided, if you see the bodybuilding.com page have tons of exercise in the database and videos are well done, they go quickly into the point that shows how to do it. |
Yes, it's very important that we use high quality resources. As for the pictures, it is not easy to come across good quality images that are under a free license such as creative commons or similar. I might be able to get my hands on some, but that won't happen soon |
We are adapting the workouts to lessons and practice drills for kids in sports. These workouts need video to show the person how it is done. Plus a video can be used to verify that an athlete is proficient at a skill and be checked off on it. Putting a video link embed from youtube is easy. Where in the exercise section could one go? |
I could imagine doing it similarly to the images, a list of videos,
perhaps with something like comment or such if e.g. the videos show
different variations or alternatives. These videos could then be shown
in the gym mode, etc.
As I said, showing a video is easy, finding them, not so much. If you
say you are adapting the workouts, you probably already found some? :)
If you do, I can look into implementing this.
Am 16.07.2017 um 00:05 schrieb Kuggaa Cuckoo Choo Choo:
… We are adapting the workouts to lessons and practice drills for kids in
sports. These workouts need video to show the person how it is done.
Plus a video can be used to verify that an athlete is proficient at a
skill and be checked off on it.
Putting a video link embed from youtube is easy. Where in the exercise
section could one go?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#344 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/ACLNGUUgbtSXgvjPE9oWWXGROzqb04s5ks5sOTeygaJpZM4KyeJu>.
|
It would be great to add this feature, added by youtube/vimeo link and embedded into the exercise description. |
This wouldn't be too hard to implement. Basically it's just a new model Video with
If someone wants to tackle this, go ahead! :) |
@rolandgeider I'll try this one. |
Go ahead :) But if you start, pull the code from #583, as there are some changes to the exercise model there |
Hi! I am a computer science student looking to contribute to an open source project. Any chance I can try to tackle this issue? |
also any other issues you need assistance on just let me know! |
Hi @ajh6 ! We've actually been working on adding images (but self hosted) and are almost done, I just hadn't uploaded the issue. What topics would you like to work on?
|
Whatever you recommend is good to start with! |
@ajh6 I'd say the one with the full text search would be the most useful right now |
There is already support for (self hosted) videos, closing this issue. We can still re-open it if we see there's need for youtube/etc references |
Hi,
I propose a section for video references for each exercise. So everyone can get a better understanding how the workout should be in motion.
A user rated collection of links might be better then just one link to one video.
Example video: https://www.youtube.com/watch?v=6MzpiWqKhmg
The text was updated successfully, but these errors were encountered: