Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video reference -- feature request #344

Closed
plus13 opened this issue Nov 15, 2016 · 15 comments
Closed

Video reference -- feature request #344

plus13 opened this issue Nov 15, 2016 · 15 comments
Assignees
Labels
effort: medium Medium effort/complexity good first issue
Milestone

Comments

@plus13
Copy link

plus13 commented Nov 15, 2016

Hi,
I propose a section for video references for each exercise. So everyone can get a better understanding how the workout should be in motion.

A user rated collection of links might be better then just one link to one video.

Example video: https://www.youtube.com/watch?v=6MzpiWqKhmg

@rolandgeider
Copy link
Member

This is a good idea. I had thought about this as well, I'm not sure if there is already an issue for this, probably not. The only thing left to do is to think on how to manage new video submissions so that we're not rickrolled or worse, but besides that, this is definitely something we should implement

@mhanuel26
Copy link

You have to use a serious source of exercise video like bodybuilding.com, take a look at this

http://www.bodybuilding.com/exercises/detail/view/name/barbell-full-squat

There you have not only video but real pictures.

You cannot relay on YouTube such the link provided, if you see the bodybuilding.com page have tons of exercise in the database and videos are well done, they go quickly into the point that shows how to do it.

@rolandgeider
Copy link
Member

Yes, it's very important that we use high quality resources. As for the pictures, it is not easy to come across good quality images that are under a free license such as creative commons or similar. I might be able to get my hands on some, but that won't happen soon

@kuggaa
Copy link

kuggaa commented Jul 15, 2017

We are adapting the workouts to lessons and practice drills for kids in sports. These workouts need video to show the person how it is done. Plus a video can be used to verify that an athlete is proficient at a skill and be checked off on it.

Putting a video link embed from youtube is easy. Where in the exercise section could one go?

@rolandgeider
Copy link
Member

rolandgeider commented Jul 19, 2017 via email

@Juanezm
Copy link

Juanezm commented Nov 5, 2020

It would be great to add this feature, added by youtube/vimeo link and embedded into the exercise description.

@rolandgeider
Copy link
Member

This wouldn't be too hard to implement. Basically it's just a new model Video with

  • url (check that it's either youtube or vimeo)
  • short description
  • foreignKey to exercise

If someone wants to tackle this, go ahead! :)

@rolandgeider rolandgeider added effort: medium Medium effort/complexity good first issue labels Nov 5, 2020
@karmenlu
Copy link

@rolandgeider I'll try this one.

@rolandgeider
Copy link
Member

Go ahead :)

But if you start, pull the code from #583, as there are some changes to the exercise model there

@ajh6
Copy link

ajh6 commented Jan 25, 2022

Hi! I am a computer science student looking to contribute to an open source project. Any chance I can try to tackle this issue?

@ajh6
Copy link

ajh6 commented Jan 25, 2022

also any other issues you need assistance on just let me know!

@rolandgeider
Copy link
Member

Hi @ajh6 !

We've actually been working on adding images (but self hosted) and are almost done, I just hadn't uploaded the issue. What topics would you like to work on?

@ajh6
Copy link

ajh6 commented Jan 25, 2022

Whatever you recommend is good to start with!

@rolandgeider
Copy link
Member

@ajh6 I'd say the one with the full text search would be the most useful right now

@rolandgeider rolandgeider self-assigned this Jan 30, 2022
@rolandgeider
Copy link
Member

There is already support for (self hosted) videos, closing this issue. We can still re-open it if we see there's need for youtube/etc references

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Medium effort/complexity good first issue
Projects
None yet
Development

No branches or pull requests

7 participants