Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split exercise translations (resolves issue #448) #583

Merged

Conversation

nikithamurikinati
Copy link
Contributor

@nikithamurikinati nikithamurikinati commented Dec 15, 2020

Proposed Changes

  • resolves issue Split exercises from translations #448
  • adds ExerciseBase class to contain language common fields (category, muscles, muscles secondary, equipment)
  • updates all exercise mentions to this new format

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • New python code has been linted with with flake8 (flake8 --config .github/linters/.flake8)
    and isort (isort)
  • Added yourself to AUTHORS.rst

Other questions

  • Does this PR introduce a breaking change such as a database migration? (i.e.
    what changes might users need to make in their running application due to
    this PR?)
    yes migrations must be rerun to update the exercises in the database to fit the new format

@rolandgeider
Copy link
Member

This is a big one, congratulations!

Here are a couple of small things:

  • I'm getting an

    AssertionError at /api/v2/exerciseinfo/
    The field 'exercise_base' was declared on serializer ExerciseInfoSerializer, but has not been included in the 'fields' option.
    

    error when visiting the new exercise info endpoint.

  • Since we have a new Exercisebase, could you add "exercises.exercisebase" to the filter-fixtures file? (the line that mentions exercises.json)

@rolandgeider rolandgeider linked an issue Jan 5, 2021 that may be closed by this pull request
@rolandgeider rolandgeider merged commit 00498ca into wger-project:master Jan 8, 2021
@rolandgeider rolandgeider added this to the 2.0 milestone Jan 8, 2021
@rolandgeider
Copy link
Member

Just merged this, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split exercises from translations
4 participants