Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add workout modal #1049

Merged
merged 1 commit into from
May 22, 2022
Merged

Fix add workout modal #1049

merged 1 commit into from
May 22, 2022

Conversation

ImTheTom
Copy link
Contributor

@ImTheTom ImTheTom commented May 22, 2022 •
edited
Loading

Proposed Changes

  • Adding a training day works via the pop up modal now.
  • Was mentioned earlier by Shemiroth in the discord on March 27th in devs channel.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features) - Not sure how to add a test for this.
  • Added yourself to AUTHORS.rst

Other questions

  • I think the issue was the combo box being rendered after the save button. Not 100% sure why this fixes it.

Showcase

Old behaviour

Old.mp4

New behaviour. Still has the same error page if you don't select a day

New.mp4

@rolandgeider rolandgeider linked an issue May 22, 2022 that may be closed by this pull request
Checkboxs for weekdays on "Add exercises to this workout day" popup modal don't seem to save. #974
Closed
@rolandgeider
Copy link
Member

🔥

@rolandgeider rolandgeider merged commit 07e1ca2 into wger-project:master May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkboxs for weekdays on "Add exercises to this workout day" popup modal don't seem to save.
2 participants
@ImTheTom @rolandgeider