Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace force_text with force_str to avoid ImportError #986

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Replace force_text with force_str to avoid ImportError #986

merged 2 commits into from
Mar 17, 2022

Conversation

sophiamartelli
Copy link
Contributor

@sophiamartelli sophiamartelli commented Mar 17, 2022 •
edited

Proposed Changes

  • This change replaces the deprecated module

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.rst

Other questions

  • Do users need to run some commmands in their local instances due to this PR
    (e.g. database migration)?
    No

@rolandgeider
Copy link
Member

Thanks for the PR! This is for django 4, right? Are there any other things that break with it?

@sophiamartelli
Copy link
Contributor Author

Hello Roland, force_text() has been deprecated in Django 3.
There are no any other issues

@rolandgeider
Copy link
Member

perfect

@rolandgeider rolandgeider merged commit c89d684 into wger-project:master Mar 17, 2022
@rolandgeider rolandgeider added this to the 2.1 milestone Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sophiamartelli @rolandgeider