Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow OS theme #29

Closed
xmha97 opened this issue May 17, 2023 · 10 comments
Closed

Follow OS theme #29

xmha97 opened this issue May 17, 2023 · 10 comments

Comments

@xmha97
Copy link

xmha97 commented May 17, 2023

Please add the dark theme to this app.

@wh201906
Copy link
Owner

It does have dark theme.

  1. Go to "settings"
    图片
  2. Select "Dark" in Appearance->Theme
    图片
  3. Click "Set" behind the Theme selector
    图片
  4. Restart the app
    图片

@xmha97
Copy link
Author

xmha97 commented May 18, 2023

Thanks, now I need another feature:

  • Please follow the system theme.

Like other apps:
Screenshot_2023-05-19-02-24-27-106_de.mm20.launcher2.release.jpg
Please add the "System" item.
Screenshot_2023-05-19-02-26-09-964_priv.wh201906.serialtest.jpg

@xmha97 xmha97 changed the title Dark Theme Follow OS theme May 19, 2023
@wh201906
Copy link
Owner

It might be a little bit hard to implement it on Qt5. I'll try it when I'm free.

@xmha97
Copy link
Author

xmha97 commented May 19, 2023

Thanks 🙏

wh201906 added a commit that referenced this issue May 21, 2023
@xmha97
Copy link
Author

xmha97 commented Jun 11, 2023

Please change "(None)" to "Follow system"
It works on Ubuntu fine.

Screenshot from 2023-06-11 15-37-12

Screenshot from 2023-06-11 15-38-20

@wh201906
Copy link
Owner

@xmha97 It's a cross-platform app and the behavior is not the same on different platforms. So I think it's not good to change the (None) to Follow System.

@wh201906
Copy link
Owner

wh201906 commented Jun 11, 2023

Plus, I think I might add more themes in the future, for both dark style and light style. However, users cannot choose which dark style to use with a single Follow System option, when the system is in dark mode.
Users can change the theme without restarting the app now (see 4d15a2f and 7b3dccb). So I guess the feature is not so necessary?

@xmha97
Copy link
Author

xmha97 commented Jun 12, 2023

Thanks for the new version.

@xmha97
Copy link
Author

xmha97 commented Jun 12, 2023

Android app does not follow OS theme, please reopen this issue.

@wh201906
Copy link
Owner

wh201906 commented Jun 12, 2023

Sorry but I don't want to add this feature for these reasons:

  1. As I mentioned in Follow OS theme #29 (comment), "Follow OS theme" is ambiguous when there are more than one dark theme.
  2. I guess you want this feature because its inconvenient for users to change the theme before V0.3.2. That's true, as they have to restart the app to do so. However, it's less necessary now because I have removed the limitation. Following OS theme is good for the user experience, but it might cost a lot of time for me to implement this because it's a Qt app.
  3. As you said in Follow OS theme #29 (comment), the default theme does follow the OS theme on Ubuntu.

@wh201906 wh201906 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants