downloader-aware scheduler cleanups #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request.meta is always a dict
also, do some bike-shedding: _pathable -> _path_safe
* PriorityAsTupleQueue.is_empty does the same as len(self) == 0 * custom PriorityAsTupleQueue.close is not needed after a switch to namedtuples * is_new and is_empty return values are unused * "url" local variable is unused
* remove mutable default arguments * more verbose variable names
scrapy/pqueues.py
Outdated
| slot = urlparse_cached(request).hostname or '' | ||
|
|
||
| # FIXME: meta is not modified when request is a dict and no meta is stored? |
There was a problem hiding this comment.
To address this concern we should preserve
Line 40 in d8e2b25
meta = request.get('meta', dict()) by meta = request.setdefault('meta', dict()) inside this code
* SlotPriorityQueues doesn't care about objects inside, it is now just a container for multiple priority queues * assorted variable renames * don't inherit DownloaderAwarePriorityQueue from SlotBasedPriorityQueue * apply @whalebot-helmsman's suggestions for __slots__ and meta issues
|
Thanks @kmike |
whalebot-helmsman
merged commit c9c349e
into
whalebot-helmsman:round-robin-scheduler-tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are rather mechanical so far, I haven't got to more complex parts yet.