Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract run to a separate package #98

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Extract run to a separate package #98

merged 1 commit into from
Oct 4, 2019

Conversation

tjamet
Copy link
Contributor

@tjamet tjamet commented Oct 2, 2019

Splitting the logic between extraction of current execution settings and actual runtime calls
This allows better testability as well as separation of concerns.
It also allows to have different implementations of the pure run interface allowing to support different runtimes whenever.

Splitting the logic between extraction of current execution settings and actual runtime calls
This allows better testability as well as separation of concerns.
It also allows to have different implementations of the pure run interface allowing to support different runtimes whenever.
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #98 into master will increase coverage by 6.02%.
The diff coverage is 81.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   40.16%   46.19%   +6.02%     
==========================================
  Files          13       15       +2     
  Lines         717      762      +45     
==========================================
+ Hits          288      352      +64     
+ Misses        405      383      -22     
- Partials       24       27       +3
Impacted Files Coverage Δ
main.go 0% <0%> (ø)
cmd/run.go 78.68% <82.75%> (+43.16%) ⬆️
run/docker.go 84.31% <84.31%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29ae94...8fc8e4f. Read the comment docs.

@tjamet tjamet merged commit 3158fcd into master Oct 4, 2019
@tjamet tjamet deleted the split-run branch October 4, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants